Skip to content

Compile with parameter names #1513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mp911de opened this issue Sep 7, 2021 · 0 comments
Closed

Compile with parameter names #1513

mp911de opened this issue Sep 7, 2021 · 0 comments
Labels
type: task A general task

Comments

@mp911de
Copy link
Member

mp911de commented Sep 7, 2021

Compiled code should contain parameter names to avoid the need for resources to be included in native image builds.

@mp911de mp911de added the type: task A general task label Sep 7, 2021
@mp911de mp911de changed the title Build sources with parameter names Compile with parameter names Sep 7, 2021
@mp911de mp911de closed this as completed in af29418 Sep 7, 2021
mp911de added a commit that referenced this issue Sep 7, 2021
mp911de added a commit that referenced this issue Sep 7, 2021
@mp911de mp911de added this to the 2.4.13 (2020.0.13) milestone Sep 7, 2021
mp911de added a commit to spring-projects/spring-data-jpa that referenced this issue Sep 14, 2021
We now no longer use compiled parameter names for tests to avoid interference with Eclipselink's mechanism of using these improperly for stored procedure calls. Especially the fact that a parameter is named "in" lets the database consider using an IN clause instead of the parameter name.

When configuring the compile plugin, we also need to ensure that the AspectJ plugin post-processes the compiled classes and doesn't run before the Maven compiler plugin.

Closes: #2298
See also spring-projects/spring-data-build#1513
mp911de added a commit to spring-projects/spring-data-jpa that referenced this issue Sep 14, 2021
We now no longer use compiled parameter names for tests to avoid interference with Eclipselink's mechanism of using these improperly for stored procedure calls. Especially the fact that a parameter is named "in" lets the database consider using an IN clause instead of the parameter name.

When configuring the compile plugin, we also need to ensure that the AspectJ plugin post-processes the compiled classes and doesn't run before the Maven compiler plugin.

Closes: #2298
See also spring-projects/spring-data-build#1513
mp911de added a commit to spring-projects/spring-data-jpa that referenced this issue Sep 14, 2021
We now no longer use compiled parameter names for tests to avoid interference with Eclipselink's mechanism of using these improperly for stored procedure calls. Especially the fact that a parameter is named "in" lets the database consider using an IN clause instead of the parameter name.

When configuring the compile plugin, we also need to ensure that the AspectJ plugin post-processes the compiled classes and doesn't run before the Maven compiler plugin.

Closes: #2298
See also spring-projects/spring-data-build#1513
trayanus1026 pushed a commit to trayanus1026/spring-data-jpa-java that referenced this issue Aug 5, 2023
We now no longer use compiled parameter names for tests to avoid interference with Eclipselink's mechanism of using these improperly for stored procedure calls. Especially the fact that a parameter is named "in" lets the database consider using an IN clause instead of the parameter name.

When configuring the compile plugin, we also need to ensure that the AspectJ plugin post-processes the compiled classes and doesn't run before the Maven compiler plugin.

Closes: #2298
See also spring-projects/spring-data-build#1513
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

No branches or pull requests

1 participant