Skip to content

3.0 Upgrade Recipe: Remove Image Banner from default location #558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
8 of 13 tasks
fabapp2 opened this issue Nov 15, 2022 · 1 comment
Closed
8 of 13 tasks

3.0 Upgrade Recipe: Remove Image Banner from default location #558

fabapp2 opened this issue Nov 15, 2022 · 1 comment
Labels
3.0.0 Spring Boot 3.0.0 good first issue Good for newcomers openrewrite Marks issues that might contain code worth contributing to OpenRewrite type: enhancement New feature or request
Milestone
v0.13.0

Comments

@fabapp2
Copy link
Contributor

fabapp2 commented Nov 15, 2022 •
edited
Loading

What needs to be done

An automated migration recipe for Image Banner Support Removed should be created.

Condition

An image banner with .gif, .png or .jpg file ending was found under src/main/resources of any module.

Report Section Issue

#150 150

DoD

  • Action implemented
    • Description provided
    • Tests (single and multi-module)
  • Declarative OpenRewrite recipe
    • Contributed to OpenRewrite
  • Condition implemented / reused
    • Description provided
    • Tests (single and multi-module)
  • Recipe YAML added
    • Test
    • Integration test for single module
    • Integration test for multi-module
  • References in report

Recipe YAML Example

This provides an example with information about how a automated migration recipe should be defined in YAML.

Report Section YAML (example) 




Additional Resources & Information


    

  • Example
    • 

  • Testing Actions
    • 

  • Testing Conditions
    • 

  • Testing Recipes
    • 

  • Integration Tests
    • 


      		
    

      
  





        



            
            

              
            

        

      


      
    








      

    



      

  
            

    

      
    

    


      

          @fabapp2
fabapp2




            added
      

  type: enhancement

  New feature or request

      

  good first issue

  Good for newcomers

      

  upgrade:boot-recipe


      

  3.0.0

  Spring Boot 3.0.0

  labels


      Nov 15, 2022

    

  








      

  
      



  

  @fabapp2





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Contributor


      

  Author


  


  

    

      

      
            fabapp2
  

      

      

      commented


        Nov 15, 2022


      
    


  





      


        


  
    

      
          
see #557 for a recipe for applications with non-default banner location

      		
    

  





        


            

            
            

              
            

        

      


      

            
  
  

    
  
    
    

  

  

  


    












      

  
            

    

      
    

    


      

          @fabapp2
fabapp2




          added this to the   v0.13.0 milestone


      Nov 15, 2022

    

  



    

    

      
    

    


      

          @fabapp2
fabapp2




          added
  the 

  openrewrite

  Marks issues that might contain code worth contributing to OpenRewrite
 label


      Nov 15, 2022

    

  



  


  
    
  
  

    
  fabapp2 

      added a commit
      that referenced
      this issue

    
      Nov 15, 2022
    
    

      


  

    

      


  

      
        @fabapp2
  





      

        
          Add recipe to remove image banner, closes #558
        

          
            
          

      


      

          

    
    
    

  

      


      

      


      
      

        
          befcb7c
        
      

    

  

    

      
- Fixing TestProjectContext when used to create a multi-module project
- Enhance PomBuilder to throw exception on API misuse
- Enhance RecipeTestSupport to use with declarative rewrite recipe
- Fix type check in ConditionDeserializer

    




    

  




  


  
    
  
  

    
  fabapp2 

      added a commit
      that referenced
      this issue

    
      Nov 22, 2022
    
    

      


  

    

      


  

      
        @fabapp2
  





      

        
          Add recipe to remove image banner, closes #558
        

          
            
          

      


      

          

    
    
    

  

      


      

      


      
      

        
          fda8bbf
        
      

    

  

    

      
- Fixing TestProjectContext when used to create a multi-module project
- Enhance PomBuilder to throw exception on API misuse
- Enhance RecipeTestSupport to use with declarative rewrite recipe
- Fix type check in ConditionDeserializer

    




    

  




    

    


  


  
    
  
  

    
  fabapp2 

      added a commit
      that referenced
      this issue

    
      Jan 31, 2023
    
    

      


  

    

      


  

      
        @fabapp2
  





      

        
          Spring Boot 3 Upgrade Report (#553)
        

          
            
          

      


      

          

    
    
    

  

      


      

      


      
      

        
          eee2f38
        
      

    

  

    

      
* Spring Boot 3 Upgrade Report Web App
* Section gets removed when running recipe succeeds, closes #551
* Move report generation into runner
* Add button and change Controller to accept all applicable recipes
* Commented out all code related to "run all recipes" button
* Section fades out before being removed
* Related section in sidebar fades out and gets removed
* page scrolls to the next section
* Moved add milestone repository for dependencies and plugins to dedicated recipe
* Moved dependency version updates to dedicated recipe
* Moved dependency version updates to dedicated recipe
* Moved recipe for javax to jakarta package change to dedicated recipe
* Moved recipe migration of spring.data properties to dedicated recipe
* Moved recipe for PagingAndSoprtingRepository to dedicated recipe
* Moved new Spring Boot 3.0 upgrade recipes to dedicated dir
* Renamed Helper to something meaningful and fixed condition
* Added missing properties to applicaiton.properties to enable git support
* Replaced tags with pinned sha for GH actions
* Prevent empty commits, closes #527
* Move ImprovedConstructorBinding into dedicated recipe and fix condition
* Fix condition for PagingAndSorting migration
* Fix condition for migrate jakarta packages migration
* Adjust replace button in SpringBootUpgradeReportTestSupport
* Rename report recipe
* Fix conditoon for PagingAndSortingHelper and use in migration
* Add withBootParentOf to TestProjectContext
* TestProjectContext supports creating pom.xml with spring*boot*parent of given version
* removed unused variable
* Fixed recipes names (#555)
* Fixing PagingAndSortingHelperTest conforming to new finder (#556)
* Add recipe to remove image banner, closes #558
* Fixing TestProjectContext when used to create a multi*module project
* Enhance PomBuilder to throw exception on API misuse
* Enhance RecipeTestSupport to use with declarative rewrite recipe
* Fix type check in ConditionDeserializer
* Moved recipes for Boot 2.7 to 3.0 upgrade to respective dirs
* Add report section and recipe to bump boot version to 3.0
* Add a flag to not re*generate report on first request
* Enhanced DependencyHelper and TestProjectContext to allow adding managed dependencies without given version
* Add upgrade dependencies report and migration
* Fix typo
* Renamed rest*service to spring*boot*upgrade
* Fix BannerSupportReportSectionTest
* Remove freemarker markup from expected output fixes SpringMvcAndWebFluxMatchinChnagesReportSectionTest
* Replace ST parsing with string replace
* rework rendering the list of authors
* Add demo for new Spring Boot Upgrade report
* Set triggermesh flag to false on test teardown
* Moved report recipe to report package (again)
* Delete obsolete file

Co*authored*by: ashakirin <[email protected]>
Co*authored*by: Sandeep Nagaraj <59915704+sanagaraj*[email protected]>

    




    

  













  
  

    

      

  





  




  
  

              

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



  






  
                  




    

  


      
  

    Assignees
  



        

    No one assigned







      


  


  

    Labels
  



    

      

    3.0.0

  Spring Boot 3.0.0
  

    good first issue

  Good for newcomers
  

    openrewrite

  Marks issues that might contain code worth contributing to OpenRewrite
  

    type: enhancement

  New feature or request








      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      
    
  
    v0.13.0
  





    
      
          


  

    

      
        

          
    

    Development
  




            
    
No branches or pull requests







      
    

  




      

    

  
      

  

    

      1 participant
    

    

        
          @fabapp2