Report sections get removed when migration recipe was applied #551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabapp2
approved these changes
Nov 14, 2022
ashakirin
pushed a commit
to sanagaraj-pivotal/spring-boot-migrator
that referenced
this pull request
Nov 15, 2022
fabapp2
added a commit
that referenced
this pull request
Nov 22, 2022
- Section gets removed when running recipe succeeds, closes #551 - Move report generation into runner - Add button and change Controller to accept all applicable recipes - Commented out all code related to "run all recipes" button - Section fades out before being removed - Related section in sidebar fades out and gets removed - page scrolls to the next section
fabapp2
added a commit
that referenced
this pull request
Nov 22, 2022
* Spring Boot 3 Upgrade Report Web App * Section gets removed when running recipe succeeds, closes #551 * Move report generation into runner * Add button and change Controller to accept all applicable recipes * Commented out all code related to "run all recipes" button * Section fades out before being removed * Related section in sidebar fades out and gets removed * page scrolls to the next section * Moved add milestone repository for dependencies and plugins to dedicated recipe * Moved dependency version updates to dedicated recipe * Moved dependency version updates to dedicated recipe * Moved recipe for javax to jakarta package change to dedicated recipe * Moved recipe migration of spring.data properties to dedicated recipe * Moved recipe for PagingAndSoprtingRepository to dedicated recipe * Moved new Spring Boot 3.0 upgrade recipes to dedicated dir * Renamed Helper to something meaningful and fixed condition * Added missing properties to applicaiton.properties to enable git support * Replaced tags with pinned sha for GH actions * Prevent empty commits, closes #527 * Move ImprovedConstructorBinding into dedicated recipe and fix condition * Fix condition for PagingAndSorting migration * Fix condition for migrate jakarta packages migration * Adjust replace button in SpringBootUpgradeReportTestSupport * Rename report recipe * Fix conditoon for PagingAndSortingHelper and use in migration * Add withBootParentOf to TestProjectContext * TestProjectContext supports creating pom.xml with spring*boot*parent of given version * removed unused variable * Fixed recipes names (#555) * Fixing PagingAndSortingHelperTest conforming to new finder (#556) * Add recipe to remove image banner, closes #558 * Fixing TestProjectContext when used to create a multi*module project * Enhance PomBuilder to throw exception on API misuse * Enhance RecipeTestSupport to use with declarative rewrite recipe * Fix type check in ConditionDeserializer * Moved recipes for Boot 2.7 to 3.0 upgrade to respective dirs * Add report section and recipe to bump boot version to 3.0 * Add a flag to not re*generate report on first request * Enhanced DependencyHelper and TestProjectContext to allow adding managed dependencies without given version * Add upgrade dependencies report and migration * Fix typo * Renamed rest*service to spring*boot*upgrade * Fix BannerSupportReportSectionTest * Remove freemarker markup from expected output fixes SpringMvcAndWebFluxMatchinChnagesReportSectionTest * Replace ST parsing with string replace * rework rendering the list of authors * Add demo for new Spring Boot Upgrade report * Set triggermesh flag to false on test teardown * Moved report recipe to report package (again) * Delete obsolete file Co*authored*by: ashakirin <[email protected]> Co*authored*by: Sandeep Nagaraj <59915704+sanagaraj*[email protected]>
fabapp2
added
type: enhancement
fabapp2
changed the title
fabapp2
added a commit
that referenced
this pull request
Jan 31, 2023
* Spring Boot 3 Upgrade Report Web App * Section gets removed when running recipe succeeds, closes #551 * Move report generation into runner * Add button and change Controller to accept all applicable recipes * Commented out all code related to "run all recipes" button * Section fades out before being removed * Related section in sidebar fades out and gets removed * page scrolls to the next section * Moved add milestone repository for dependencies and plugins to dedicated recipe * Moved dependency version updates to dedicated recipe * Moved dependency version updates to dedicated recipe * Moved recipe for javax to jakarta package change to dedicated recipe * Moved recipe migration of spring.data properties to dedicated recipe * Moved recipe for PagingAndSoprtingRepository to dedicated recipe * Moved new Spring Boot 3.0 upgrade recipes to dedicated dir * Renamed Helper to something meaningful and fixed condition * Added missing properties to applicaiton.properties to enable git support * Replaced tags with pinned sha for GH actions * Prevent empty commits, closes #527 * Move ImprovedConstructorBinding into dedicated recipe and fix condition * Fix condition for PagingAndSorting migration * Fix condition for migrate jakarta packages migration * Adjust replace button in SpringBootUpgradeReportTestSupport * Rename report recipe * Fix conditoon for PagingAndSortingHelper and use in migration * Add withBootParentOf to TestProjectContext * TestProjectContext supports creating pom.xml with spring*boot*parent of given version * removed unused variable * Fixed recipes names (#555) * Fixing PagingAndSortingHelperTest conforming to new finder (#556) * Add recipe to remove image banner, closes #558 * Fixing TestProjectContext when used to create a multi*module project * Enhance PomBuilder to throw exception on API misuse * Enhance RecipeTestSupport to use with declarative rewrite recipe * Fix type check in ConditionDeserializer * Moved recipes for Boot 2.7 to 3.0 upgrade to respective dirs * Add report section and recipe to bump boot version to 3.0 * Add a flag to not re*generate report on first request * Enhanced DependencyHelper and TestProjectContext to allow adding managed dependencies without given version * Add upgrade dependencies report and migration * Fix typo * Renamed rest*service to spring*boot*upgrade * Fix BannerSupportReportSectionTest * Remove freemarker markup from expected output fixes SpringMvcAndWebFluxMatchinChnagesReportSectionTest * Replace ST parsing with string replace * rework rendering the list of authors * Add demo for new Spring Boot Upgrade report * Set triggermesh flag to false on test teardown * Moved report recipe to report package (again) * Delete obsolete file Co*authored*by: ashakirin <[email protected]> Co*authored*by: Sandeep Nagaraj <59915704+sanagaraj*[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.