Skip to content

3.0.0-M2 Image Banner Support Removed #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
2 tasks
Tracked by #163
fabapp2 opened this issue Jun 13, 2022 · 3 comments · Fixed by #499
Closed
2 tasks
Tracked by #163

3.0.0-M2 Image Banner Support Removed #150

fabapp2 opened this issue Jun 13, 2022 · 3 comments · Fixed by #499
Labels
3.0.0 Spring Boot 3.0.0 good first issue Good for newcomers upgrade:boot-report
Milestone
Spring Boot Upgra...

Comments

@fabapp2
Copy link
Contributor

fabapp2 commented Jun 13, 2022 •
edited
Loading

https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-3.0.0-M2-Release-Notes#image-banner-support-removed

What needs to be done

If banner.gif, banner.jpg, or banner.png are found warn the user in the report about removed support of images as banner

  • Check if banner.gif, banner.jpg, or banner.png exist
  • Create report and ask user to replace the banner with a banner.txt file

Additional Information

See DatabaseDriverGaeFinder and DatabaseDriverGaeSectionBuilder
@fabapp2 fabapp2 added this to the Spring Boot Upgrade 3.0 (M3) milestone Jun 13, 2022
@fabapp2 fabapp2 changed the title Image Banner Support Removed 3.0.0-M2 Image Banner Support Removed Jun 13, 2022
@fabapp2 fabapp2 mentioned this issue Jun 13, 2022
Closed
7 tasks
@sanagaraj-pivotal
Copy link
Contributor

ready to be picked up, decide what to do.

@fabapp2 fabapp2 added 3.0.0 Spring Boot 3.0.0 and removed 3.0.0-M2 labels Jul 21, 2022
@fabapp2
Copy link
Contributor Author

fabapp2 commented Sep 27, 2022

To check off M2 changes (this seems to be the last missing) I'd say let's create this report section.

@sanagaraj-pivotal sanagaraj-pivotal mentioned this issue Oct 24, 2022
Merged
@fabapp2
Copy link
Contributor Author

fabapp2 commented Nov 15, 2022

Enhance recipe to deal with spring.banner.location=... property pointing to a non-default location

This was referenced Nov 15, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.0.0 Spring Boot 3.0.0 good first issue Good for newcomers upgrade:boot-report
Projects
None yet
Milestone
Spring Boot Upgrade 3.0 (M3)
Development

Successfully merging a pull request may close this issue.

Add removal of Image Banner to report sanagaraj-pivotal/spring-boot-migrator
2 participants
@fabapp2 @sanagaraj-pivotal