Skip to content

fix broken windows path #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 18, 2018
Merged

fix broken windows path #247

merged 6 commits into from
Sep 18, 2018

Conversation

vecchp
Copy link
Contributor

@vecchp vecchp commented Sep 17, 2018 •
edited
Loading

Current version seems to handle windows paths improperly

docker: Error response from daemon: Mount denied:
The source path "C\\:/Users/Paul/Development/solidangle/match-api/app/.serverless/requirements\\:/var/task\\"
is not a valid Windows path.
See 'docker run --help'.

Calling dockerPathForWin on bindPath creation resolves issue.

@dschep
Copy link
Contributor

dschep commented Sep 17, 2018

Could you run yarn format and commit the changes?

This was referenced Sep 17, 2018
Closed
Closed
dschep
dschep approved these changes Sep 18, 2018
View reviewed changes
Copy link
Contributor

@dschep dschep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dschep dschep merged commit c5d9315 into serverless:master Sep 18, 2018
dschep added a commit that referenced this pull request Sep 18, 2018
@dschep
version bump for #247
8b06b7c
@dschep dschep mentioned this pull request Sep 19, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dschep dschep dschep approved these changes

Assignees
No one assigned
Labels
bug Windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vecchp @dschep