Skip to content

Docker build fails if space in Path #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JonnyWaffles opened this issue Apr 29, 2018 · 5 comments
Closed

Docker build fails if space in Path #184

JonnyWaffles opened this issue Apr 29, 2018 · 5 comments

Comments

@JonnyWaffles
Copy link
Contributor

JonnyWaffles commented Apr 29, 2018

Hi. When trying to build a test project following this tutorial on Windows 10 in the following directory C:\Users\Jonny Waffles\PycharmProjects\numpy_test I received the following error during deployment:


  Error --------------------------------------------------

  docker: invalid reference format: repository name must be lowercase.
See 'docker run --help'.

However, if I built the project out of a directory with no spaces it succeeded:

C:\testproject

@JonnyWaffles
Copy link
Contributor Author

#187 Fixed here.

@rob-deans
Copy link

Still have the same problem with this, have version 4.2.2.

My path does have a spaces in, moving to another again succeeds

@dschep
Copy link
Contributor

dschep commented Sep 18, 2018

@rob-deans what OS are you on?

@rob-deans
Copy link

Windows 10 Pro v 1803

@dschep
Copy link
Contributor

dschep commented Sep 19, 2018

Ahh. Ok. I was gonna be surprised if it wasn,t since there's test coverage for that, but tests are run on linux in CI only. see #249 for more about that. As for the bug. good catch. @vecchp, you removed quoting on windows in #247. Do you know if there's a windows equivalent of shell-quote? Looks like #187 initially fixed this by just throwing quotes around it. Maybe dockerPathForWin should do that?

@dschep dschep reopened this Sep 19, 2018
dschep added a commit that referenced this issue Sep 19, 2018
@dschep dschep closed this as completed in 3b2c245 Sep 20, 2018
dschep added a commit that referenced this issue Nov 1, 2018
* Fixes issues with spaces in path on windows #184
* More windows path issues #252
* fix issues when using pip-tools with hashes #261
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants