Skip to content

4.2.1 introduces requirements path problem in Windows #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hubbins opened this issue Sep 17, 2018 · 5 comments
Closed

4.2.1 introduces requirements path problem in Windows #248

hubbins opened this issue Sep 17, 2018 · 5 comments

Comments

@hubbins
Copy link

hubbins commented Sep 17, 2018

4.2.0 works correctly

This path gets changed from:
D:\work\git\something-game\game-rank-notifier.serverless\requirements

To:
D\:\\work\\git\\something-game\\game-rank-notifier\\.serverless\\requirements

By the newly added function quote_single(). This doesn't seem to have been tested in Windows.

Thanks

@hubbins
Copy link
Author

hubbins commented Sep 17, 2018

Edited initial post to put the "To" path in a code block to preserve formatting.

@hubbins hubbins changed the title 4.2.2 introduces requirements path problem in Windows 4.2.1 introduces requirements path problem in Windows Sep 17, 2018
@dschep
Copy link
Contributor

dschep commented Sep 17, 2018

#247 will fix this AFAIK.

@hubbins
Copy link
Author

hubbins commented Sep 17, 2018

Actually 4.2.2 introduced this, but it doesn't seem like there were changes in this area for 4.2.2?

@hubbins
Copy link
Author

hubbins commented Sep 17, 2018

#247 will fix this AFAIK.

Seems like it. Thanks

@dschep
Copy link
Contributor

dschep commented Sep 18, 2018

Released fix as v4.2.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants