Skip to content

Broken coloring of identifiers with letters ÅÄÖ åäö #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bjornregnell opened this issue May 15, 2018 · 2 comments · Fixed by #29
Closed

Broken coloring of identifiers with letters ÅÄÖ åäö #5

bjornregnell opened this issue May 15, 2018 · 2 comments · Fixed by #29

Comments

@bjornregnell
Copy link

If letters åäö or ÅÄÖ (used e.g. in Swedish, German etc) appear in an identifier the coloring breaks:
scala
It works for Java though using the built in java syntax package:
java
Tested in vscode v1.23.1 using vscode-scala-syntax v0.1.2
The bug only appears in some color themes, e.g. Dark+ (default dark) and Monokai Dimmed. Above images grabbed with color theme Atom One Dark.

@wpug
Copy link

wpug commented May 7, 2019

The bug is still there (for the Polish letters in my case – such as ą,ę,ś,ć etc). It appears in some color themes only, because only some of them seem to distinguish identifier declarations... If it is not possible to make the highlighting work "in general" then maybe a configuration option for "allowed identifier symbols" can be added?

PanAeon added a commit to PanAeon/vscode-scala-syntax that referenced this issue May 27, 2019
…egexes for val,def,import,parameter-list,package,type. Minor clean up. Added unit test for unicode

ids.
@olafurpg
Copy link
Contributor

This fix has now been released as part of 0.3.2 (https://github.com/scala/vscode-scala-syntax/releases/tag/v0.3.2), thank you for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants