Skip to content

Fix highlighting for symbolic symbol literals #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 27, 2019
Merged

Fix highlighting for symbolic symbol literals #28

merged 1 commit into from
May 27, 2019

Conversation

PanAeon
Copy link
Contributor

@PanAeon PanAeon commented May 25, 2019

fix #10
add unit test for symbols
add .metals to .gitignore

olafurpg
olafurpg approved these changes May 27, 2019
View reviewed changes
Copy link
Contributor

@olafurpg olafurpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 This is a great fix! I look forward to enjoying the improved highlighting both in vscode and on github.com 😊

@olafurpg olafurpg requested a review from nicolasstucki May 27, 2019 12:21
@olafurpg olafurpg merged commit e706a1e into scala:master May 27, 2019
@olafurpg
Copy link
Contributor

@PanAeon What do you think about cutting a new release with this fix?

@PanAeon
Copy link
Contributor Author

PanAeon commented May 27, 2019

@olafurpg I'm working on #5 right now, so maybe it makes sense to wait a few days..

@olafurpg olafurpg changed the title broken single quote symbol Fix highlighting for symbolic symbol literals May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olafurpg olafurpg olafurpg approved these changes

@nicolasstucki nicolasstucki nicolasstucki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken single quote symbol
3 participants
@PanAeon @olafurpg @nicolasstucki