Skip to content

Fix highlighting of non-ascii variable names #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2019

Conversation

PanAeon
Copy link
Contributor

@PanAeon PanAeon commented May 27, 2019

Updated identifiers regexes for val,def,import,parameter-list,package,type.
Minor clean up (removed artifacts of prior xml conversion).
Added unit test for unicode identifiers.

fixes #5

…egexes for val,def,import,parameter-list,package,type. Minor clean up. Added unit test for unicode

ids.
Copy link
Contributor

@olafurpg olafurpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tried this out locally and it works great 👏 A big improvement

Before

Screenshot 2019-05-28 at 08 24 58

After

Screenshot 2019-05-28 at 08 24 28

LGTM 👍 Thank you @PanAeon!

@olafurpg olafurpg requested a review from nicolasstucki May 28, 2019 06:26
@nicolasstucki nicolasstucki merged commit 00b3da5 into scala:master May 28, 2019
@olafurpg olafurpg changed the title broken ids with unicode characters. Fix highlighting of non-ascii variable names May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken coloring of identifiers with letters ÅÄÖ åäö
3 participants