Fix #8045: Refine QuoteContext{val tasty} provided by splices #8281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
fix-#8045
branch
from
ceb0cbe to
2f1bd68
Compare
* Avoids leaking implementation details of scala.internal.quoted.CompileTime.exprQuote, such as exprQuote returning a ?=> function argument
```
given qctx as QuoteContex = ???
'{
${ myExpr(summon[QuoteContext]) }
}
```
is now encoded as
```
given qctx as QuoteContex = ???
exprQuote {
exprSplice {
(qctx0_$1: qctx.NestedContext) ?=>
myExpr(summon[QuoteContext](qctx0_$1))
}
}(given qctx)
```
Before `qctx0_$1` was typed as `QuoteContext`.
Intuitively, `qctx0_$1` is a sub-context of `qctx` where both share the same reflection interface
nicolasstucki
force-pushed
the
fix-#8045
branch
from
ba25250 to
1b24694
Compare
liufengyun
reviewed
Feb 12, 2020
| * The quotation stack could be empty if we are in a top level splice or an eroneous splice directly witin a top level splice. | ||
| */ | ||
| def popQuoteContext()(implicit ctx: Context): (Option[tpd.Tree], Context) = | ||
| val ctx1 = ctx.fresh.setProperty(QuotationLevel, level - 1) |
There was a problem hiding this comment.
The property QuotationLevel is also mutated in spliceContext and quoteContext. This may cause accidental errors when used without care. Maybe remove spliceContext and quoteContext, since they are not used.
There was a problem hiding this comment.
We use those in PCPCheckAndHeal and ReifyQuotes. There we only need to track the level.
| def pushQuoteContext(qctxRef: tpd.Tree)(implicit ctx: Context): Context = | ||
| val old = ctx.property(QuoteQontextStack).getOrElse(List.empty) | ||
| ctx.fresh.setProperty(QuotationLevel, level + 1) | ||
| .setProperty(QuoteQontextStack, qctxRef :: old) |
There was a problem hiding this comment.
I'm wondering if the stack can be avoided using scoping rules for implicits.
There was a problem hiding this comment.
Yes, it could but we would need to track a level context and a splice context. The errors when those implicit are not found would also be hard to interpret.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.