Explicitly search the given QuoteContext of the quotes #8262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Avoids leaking implementation details of scala.internal.quoted.CompileTime.exprQuote, such as exprQuote returning a ?=> function argument
liufengyun
reviewed
Feb 10, 2020
| else if (tree.quoted.isType) | ||
| typedTypeApply(untpd.TypeApply(untpd.ref(defn.InternalQuoted_typeQuote.termRef), tree.quoted :: Nil), pt)(quoteContext) | ||
| else | ||
| typedApply(untpd.Apply(untpd.ref(defn.InternalQuoted_exprQuote.termRef), tree.quoted), pt)(quoteContext).select(nme.apply).appliedTo(qctx) |
There was a problem hiding this comment.
I'm not sure about this line, as previously, we don't need to .select(nme.apply).appliedTo(qctx), and it worked.
There was a problem hiding this comment.
Previously we were letting typer find and apply it. But as we know it we can just add it explicitly. In the previous case, it did not find the implicit it emitted an error mentioning CompileTime.quotedExpr in some situations.
| @@ -45,10 +45,16 @@ trait QuotesAndSplices { | |||
| ctx.warning("Canceled splice directly inside a quote. '[ ${ XYZ } ] is equivalent to XYZ.", tree.sourcePos) | |||
| case _ => | |||
| } | |||
| val qctx = inferImplicitArg(defn.QuoteContextClass.typeRef, tree.span) | |||
There was a problem hiding this comment.
Inferring implicit args for implicit function types complicate existing typing rules. It's better to avoid the special case and only use it as a last resort.
There was a problem hiding this comment.
Will be required in #8281
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
such as exprQuote returning a ?=> function argument
Same as #8244 but on quotes