Skip to content

Explicitly provide the given QuoteContext of the splice #8244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

nicolasstucki
Copy link
Contributor

  • Avoids leaking implementation details of scala.internal.quoted.CompileTime.exprSplice,
    such as exprSplice taking a ?=> function argument
  • Provide meaningful names for QuoteContext synthesized by within ${ ... }

@nicolasstucki nicolasstucki self-assigned this Feb 7, 2020
 * Avoids leaking implementation details of scala.internal.quoted.CompileTime.exprSplice,
   such as exprSplice taking a ?=> function argument
 * Provide meaningful names for QuoteContext synthesized by within `${ ... }`
@nicolasstucki nicolasstucki force-pushed the handle-quote-context-splice branch from 583f9ac to 51a15d6 Compare February 7, 2020 16:16
@nicolasstucki nicolasstucki marked this pull request as ready for review February 7, 2020 18:48
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicolasstucki nicolasstucki merged commit c228b36 into scala:master Feb 9, 2020
@nicolasstucki nicolasstucki deleted the handle-quote-context-splice branch February 9, 2020 11:51
@anatoliykmetyuk anatoliykmetyuk added this to the 0.23.0-RC1 milestone Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants