Add typeChecks to the library #6175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow up of scala#6135
liufengyun
approved these changes
Mar 26, 2019
| private def typeChecksImpl(code: String)(implicit reflect: Reflection): Expr[Boolean] = { | ||
| import reflect._ | ||
| typing.typeChecks(code).toExpr | ||
| } |
There was a problem hiding this comment.
Maybe remove private, as inlining will create an accessor if it's private.
Can we use top-level definitions to get rid of object TypeChecking?
Regarding scala.tests, what about scala.test?
There was a problem hiding this comment.
I will try the top level definition and change to scala.test. typeChecksImpl must be private or it would be visible under import scala.test.
There was a problem hiding this comment.
In the future, we will also support arbitrary code in top-level splices. Which will allow us to implement it like
inline def typeChecks(inline code: String): Boolean = ${
val reflect = implicitly[Reflection]
import reflect._
typing.typeChecks(code).toExpr
}
nicolasstucki
force-pushed
the
add-typeChecks-2
branch
from
7449459 to
dc0a51a
Compare
ghost
removed
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #6135