-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add typeChecks to tasty reflect #6135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
784df7f
to
90371d2
Compare
Why not expose a |
@LPTK There is worry that it is too much power to programmers. |
@LPTK If we can find a concrete justified usage for the API you proposed, I think maybe we can support it. |
Well, for one thing it would allow me to reimplement the basics of Squid's quasiquote system. I need to instrument and put together the string parts from the interpolator, parse and type check the result, and inspect the corresponding typed tree. Errors during type checking should bubble up to the user (they won't have useful positions, though). Note that Squid quasiquotes do more than Dotty's quasiquotes (they track scopes statically and therefore allow type-safe effectful code generation), so they could still have some uses in Scala 3. |
@LPTK your use case is a valid one which should be tackled but is not in the current scope of the PR. We want to have something simpler first, which we can test and make sure works in a shorter timeframe. The current aim of this is to support the functionality of scalatest which is a blocker for the entier community. |
addressed in the last commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM
Follow up of scala#6135
Add typeChecks to tasty reflect