Allow top-level splices not directly in the RHS #4826
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
fix-#4801
branch
3 times, most recently
from
b8b3cc0 to
00fd323
Compare
* top-level ~ must contain a call to a static method * arguments must be quoted * inline arguments can be passed directly * removed dependency on the original inlined code (removed in PostTyper) * ReifyQuotes is no longer an InfoTransformer * Splicer implements both checking and evaluation of splices in a single abstraction * Fix scala#4773 * Fix scala#4735
Now all levels are relative to the definition site. 0 is the level of all non-staged definitions, -1 is the level of the contents of a top level splice (in an inline method) and positive levels are (as before) staging levels.
Allow top-level ~ in and non static transparent method: * Class methods (including inner and anonymous classes) * Methods in def/val/var
nicolasstucki
force-pushed
the
fix-#4801
branch
2 times, most recently
from
dbe1b4c to
a87cf6d
Compare
nicolasstucki
force-pushed
the
fix-#4801
branch
4 times, most recently
from
f4532e3 to
002e3b4
Compare
nicolasstucki
changed the title
For example a transparent method can be defined as ``` transparent def foo(b: Boolean): Int = if (b) ~bar(true) else ~bar(false) ``` Removing this restriction also allows us to have a simpler implementation of splicing and transparent def checking. Removes last use of `Macro` flag in `ReifyQuotes`.
nicolasstucki
added
stat:wip
stat:on hold
stat:revisit
and removed
stat:needs rebase
stat:on hold
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #4823, followed by #4855