Enable macros in any transparent def #4823
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 23, 2018
nicolasstucki
force-pushed
the
fix-#4803
branch
2 times, most recently
from
e11b714 to
16a463f
Compare
nicolasstucki
changed the title
nicolasstucki
force-pushed
the
fix-#4803
branch
2 times, most recently
from
dea5b08 to
c27ca82
Compare
Now all levels are relative to the definition site. 0 is the level of all non-staged definitions, -1 is the level of the contents of a top level splice (in an inline method) and positive levels are (as before) staging levels.
Allow top-level ~ in and non static transparent method: * Class methods (including inner and anonymous classes) * Methods in def/val/var
|
Rebased on master |
biboudis
approved these changes
Jul 30, 2018
| @@ -103,14 +103,16 @@ class ReifyQuotes extends MacroTransformWithImplicits { | |||
| /** The main transformer class | |||
| * @param inQuote we are within a `'(...)` context that is not shadowed by a nested `~(...)` | |||
| * @param outer the next outer reifier, null is this is the topmost transformer | |||
| * @param level the current level, where quotes add one and splices subtract one level | |||
| * @param level the current level, where quotes add one and splices subtract one level. | |||
| * The initial level is 0, a level `l` where `l > 0` implies code has been quotes `l` times | |||
| * @param level the current level, where quotes add one and splices subtract one level | ||
| * @param level the current level, where quotes add one and splices subtract one level. | ||
| * The initial level is 0, a level `l` where `l > 0` implies code has been quotes `l` times | ||
| * and `l == -1` is code inside a top level splice (in an transparent method). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #4822.
Allow top-level ~ in and non static transparent method:
Followed by #4826.