Fix #4846: Allow transparent parameters at any stage #4856
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rebased on master |
Stop checking and using capture tranformation for transparent parameters
biboudis
approved these changes
Jul 31, 2018
| case _=> | ||
| val (body1, splices) = nested(isQuote = true).split(body) | ||
| if (level >= 0) pickledQuote(body1, splices, body.tpe, isType).withPos(quote.pos) | ||
| if (level == 0 && !ctx.inTransparentMethod) pickledQuote(body1, splices, body.tpe, isType).withPos(quote.pos) |
There was a problem hiding this comment.
Small question. We don't split if we are in a transparent method but the level is above or equal zero?
If yes, we can move splitting inside the if now.
There was a problem hiding this comment.
We do not split, but we still need to perform the checks that split does. We should be able to improve the performance by calling transform directly in another branch. I will try that later, nice catch :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #4823