Skip to content

Allow multiple splices in macros #4801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nicolasstucki opened this issue Jul 18, 2018 · 4 comments
Closed

Allow multiple splices in macros #4801

nicolasstucki opened this issue Jul 18, 2018 · 4 comments
Labels
area:metaprogramming:quotes Issues related to quotes and splices itype:enhancement stat:on hold stat:revisit

Comments

@nicolasstucki
Copy link
Contributor

nicolasstucki commented Jul 18, 2018 •
edited
Loading

We want to be able to write macros that have several top level splices such as

inline def foo(b: Boolean): Int = {
  if (b) ${bar(true)}
  else ${bar(false)}
}
def bar(b: Boolean)(using QuoteContext): Expr[Int] = if (b) '{1} else '{0}
@nicolasstucki nicolasstucki self-assigned this Jul 18, 2018
@nicolasstucki nicolasstucki mentioned this issue Jul 18, 2018
Closed
nicolasstucki added a commit to dotty-staging/dotty that referenced this issue Jul 18, 2018
@nicolasstucki
Fix scala#4801: Allow multiple splices in macros
63cfe8c
@nicolasstucki
Copy link
Contributor Author

To allow macros in classes and any non-static location this is a compromise we have to do.

@Blaisorblade
Copy link
Contributor

Is the restriction documented?

@nicolasstucki
Copy link
Contributor Author

Woking on it

@nicolasstucki
Copy link
Contributor Author

This might actually be possible dot do.

@nicolasstucki nicolasstucki reopened this Jul 21, 2018
nicolasstucki added a commit to dotty-staging/dotty that referenced this issue Jul 23, 2018
@nicolasstucki
Fix scala#4801: WIP
844f662
nicolasstucki added a commit to dotty-staging/dotty that referenced this issue Jul 23, 2018
@nicolasstucki
Fix scala#4801: WIP
2192264
nicolasstucki added a commit to dotty-staging/dotty that referenced this issue Jul 24, 2018
@nicolasstucki
Fix scala#4801: WIP
b8b3cc0
nicolasstucki added a commit to dotty-staging/dotty that referenced this issue Jul 24, 2018
@nicolasstucki
Fix scala#4801: WIP
00fd323
nicolasstucki added a commit to dotty-staging/dotty that referenced this issue Jul 27, 2018
@nicolasstucki
Fix scala#4801: WIP
dbe1b4c
nicolasstucki added a commit to dotty-staging/dotty that referenced this issue Jul 27, 2018
@nicolasstucki
Fix scala#4801: WIP
a87cf6d
nicolasstucki added a commit to dotty-staging/dotty that referenced this issue Jul 27, 2018
@nicolasstucki
Fix scala#4801: WIP
2ce700c
nicolasstucki added a commit to dotty-staging/dotty that referenced this issue Jul 27, 2018
@nicolasstucki
Fix scala#4801: WIP
33da992
nicolasstucki added a commit to dotty-staging/dotty that referenced this issue Jul 27, 2018
@nicolasstucki
Fix scala#4801: WIP
f4532e3
nicolasstucki added a commit to dotty-staging/dotty that referenced this issue Jul 27, 2018
@nicolasstucki
Fix scala#4801: Allow top-level splices not directly in the RHS
002e3b4 
For example a transparent method can be defined as
```
transparent def foo(b: Boolean): Int =
  if (b) ~bar(true)
  else ~bar(false)
```

Removing this restriction also allows us to have a simpler implementation
of splicing and transparent def checking.
nicolasstucki added a commit to dotty-staging/dotty that referenced this issue Jul 27, 2018
@nicolasstucki
Fix scala#4801: Allow top-level splices not directly in the RHS
e582343 
For example a transparent method can be defined as
```
transparent def foo(b: Boolean): Int =
  if (b) ~bar(true)
  else ~bar(false)
```

Removing this restriction also allows us to have a simpler implementation
of splicing and transparent def checking.
nicolasstucki added a commit to dotty-staging/dotty that referenced this issue Jul 27, 2018
@nicolasstucki
Fix scala#4801: Allow top-level splices not directly in the RHS
be05e0f 
For example a transparent method can be defined as
```
transparent def foo(b: Boolean): Int =
  if (b) ~bar(true)
  else ~bar(false)
```

Removing this restriction also allows us to have a simpler implementation
of splicing and transparent def checking.

Removes last use of `Macro` flag in `ReifyQuotes`.
@nicolasstucki nicolasstucki removed their assignment Sep 19, 2018
@nicolasstucki nicolasstucki added area:metaprogramming:quotes Issues related to quotes and splices and removed area:metaprogramming labels Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:metaprogramming:quotes Issues related to quotes and splices itype:enhancement stat:on hold stat:revisit
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Decoupling Macros in ReifyQuotes dotty-staging/dotty
2 participants
@Blaisorblade @nicolasstucki