Add native Dotty REPL #2991

felixmulder · 2017-08-17T12:43:04Z

Adding this here to check using CI that all is well in the world so far.

Will probably be ready for review in a day or two.

OlivierBlanvillain · 2017-08-23T09:20:56Z

#1440 and #2554 are fixed in the new repl, we should close these and delete the area:old-repl label after merge :)

OlivierBlanvillain · 2017-08-23T08:58:50Z

compiler/src/dotty/tools/dotc/core/StdNames.scala

+    final val REPL_ASSIGN_SUFFIX = "$assign"
+    final val REPL_RES_PREFIX    = "res"
+
+    // TODO: remove!


OlivierBlanvillain · 2017-08-23T09:25:10Z

compiler/test/dotty/tools/dotc/CompilationTests.scala

@@ -197,7 +197,6 @@ class CompilationTests extends ParallelTesting {
    compileDir("../compiler/src/dotty/tools/dotc/config", picklingOptions) +
    compileDir("../compiler/src/dotty/tools/dotc/parsing", picklingOptions) +
    compileDir("../compiler/src/dotty/tools/dotc/printing", picklingOptions) +
-    compileDir("../compiler/src/dotty/tools/dotc/repl", picklingOptions) +


I wonder if it would make sense to keep all that code somewhere under /tests given that it helped detect some nasty pattern matching edge cases... WDYT?

Maybe, it still has the same components, so adding this should be trivial 👍

OlivierBlanvillain · 2017-08-23T09:27:29Z

project/Build.scala

+      `dotty-compiler`,
+      `dotty-compiler` % "test->test"
+    ).
+    settings(commonNonBootstrappedSettings).


I thought we the repl would be both complied by scala and bootstrapped?

Oh I guess adding the sources in dottyCompilerSettings does the trick...

OlivierBlanvillain · 2017-08-23T09:36:09Z

repl/src/dotty/tools/repl/ParseResult.scala

+      |:load <path>             interpret lines in a file
+      |:quit                    exit the interpreter
+      |:type <expression>       evaluate the type of the given expression
+      |:reset                   reset the repl to its initial state, forgetting all session entries


:imports is missing from that list

OlivierBlanvillain · 2017-08-23T09:39:37Z

repl/src/dotty/tools/repl/ParseResult.scala

+  val text =
+    """The REPL has several commands available:
+      |
+      |:help                    print this summary or command-specific help


The command-specific part is not implemented

OlivierBlanvillain · 2017-08-23T13:53:00Z

repl/src/dotty/tools/repl/terminal/Filter.scala

+package repl
+package terminal
+
+/**


Old school scaladoc comments?

ammonite strikes again!

OlivierBlanvillain · 2017-08-23T13:57:53Z

repl/test/dotty/tools/repl/CompilerTests.scala

+                       "val res0: Int = 2",
+                       "var y: Int = 5")
+
+    expected === storedOutput().split("\n")


What does === do with a Set and an Array oO?

it's a cooooool thingy that sorts, asserts and prints if assertion fails

OlivierBlanvillain · 2017-08-23T13:59:53Z

repl/test/dotty/tools/repl/ScriptedTests.scala

+
+import dotc.reporting.MessageRendering
+
+/** Runs all tests contained withing `/repl/test-resources/scripts` */


s/withing/in/

OlivierBlanvillain · 2017-08-23T14:03:15Z

sbt-bridge/src/xsbt/ConsoleInterface.scala

@@ -20,6 +19,24 @@ class ConsoleInterface {
  def run(args: Array[String],
          bootClasspathString: String,
          classpathString: String,
+          // TODO: initial commands needs to be run under some form of special


Should we make an issue out of this?

There is: #3007

OlivierBlanvillain · 2017-08-23T14:06:33Z

repl/src/dotty/tools/repl/AmmoniteReader.scala

+      AnsiNav.resetForegroundColor
+    )
+
+    val autocompleteFilter: Filter = Filter.action("autocompleteFilter")(SpecialKeys.Tab :: Nil) {


I think the completion behavior is a bit too aggressive, at least compared to my bash habits:

$ touch equals $ touch equalsIgnoreCase $ cat equ # Press tab equals equalsIgnoreCase $ cat equals # Press tab again equals equalsIgnoreCase $ cat equals # and again equals equalsIgnoreCase

scala> "".equ // Press tab equals equalsIgnoreCase scala> "".equals // Press tab again equalsIgnoreCase scala> "".equalsIgnoreCase // and again

Maybe, but that's the way it's implemented in ammonite. We could probably enhance it so that you get a more bash-like behaviour. But IMO outside of the scope of this PR being merged :)

Low-hanging fruit perhaps?

If the show member is a value, then when mutation ocurs in the real value - the shown value will not reflect the change.

Previously if user code was equal to null, then the accompanying show method would in effect call `null.show` which would crash the repl in a mysterious way.

OlivierBlanvillain

LGTM!

rom1dep · 2017-08-29T03:03:10Z

FYI, on a clean clone,

./bin/dotr
The script is going to build the required jar files
Building dotty-interfaces...done
Building dotty-compiler...done
Building dotty library...done
Building tests...done
Starting dotty REPL...
Error: Could not find or load main class dotty.tools.dotc.repl.Main

felixmulder · 2017-08-29T06:49:53Z

@rom1dep: #3026

felixmulder force-pushed the topic/new-repl branch 8 times, most recently from 812f141 to 2fd10d9 Compare August 22, 2017 18:32

OlivierBlanvillain self-requested a review August 23, 2017 08:46

OlivierBlanvillain self-assigned this Aug 23, 2017

OlivierBlanvillain mentioned this pull request Aug 23, 2017

REPL breaks when complicated type is inferred #2554

Closed

felixmulder force-pushed the topic/new-repl branch from 8d15906 to 83bacf2 Compare August 23, 2017 12:45

felixmulder added 17 commits August 23, 2017 15:13

Add initial scaffolding for REPL project

7687f4b

Add ammonite sources and implement prompt with highlighting

cb1332c

Add multiline support

11dceca

Apply workaround for scala#2711

a40175e

Refactor side-effecty logic in AmmoniteReader

f9d48ec

Replace command by ADT

a7a7c9a

Fix sbt run in dotty-repl

a7b5460

Get rid of interactive compiler in REPL

c96ce66

Implement compilation without need for reparsing trees

38e2649

Move typechecking to throwaway class

e6f678b

Turn ReplCompiler into ReplTyper

0a3532d

Clean up compilation logic, make union decorator work

905ada0

Add crash tests

358c3a9

Add test for tree injector

774a21f

Implement fresh injection of trees into ReplSession object

8b1352d

Use single compiler instance instead of split pipeline

1b129cd

Modularize compilation steps

3520967

felixmulder force-pushed the topic/new-repl branch from 6aed7ac to fade8b8 Compare August 23, 2017 13:18

OlivierBlanvillain reviewed Aug 23, 2017

View reviewed changes

felixmulder added 17 commits August 23, 2017 17:50

Use StdNames constants instead of hardcoded literals

9e44871

Make the show member a DefDef

2372340

If the show member is a value, then when mutation ocurs in the real value - the shown value will not reflect the change.

Get rid of hardcoded library in repl tests

96daa58

Remove more duplication from UserFacingPrinter

6ae8853

Change Driver API to not need definition of newCompiler

c9e6074

Remove newCompiler override from ReplDriver

a6b0aa1

Make sure compilation yields a state with a new Run

9a0a742

Fix missing case for widlcard in UserFacingPrinter

1375e79

Kill old REPL with 🔥

0aa7533

Temporarily disable console in sbt bridge

64862a0

Turn dotty-repl project into a Scala 2 project

bc48498

Make new REPL work with sbt bridge

ec6fbbb

Replace Result with right biased Either alias

5f8672c

Add instructions on how to add initialCommands to REPL

d601fdf

Add null-check to <id>Show method

8c78e9a

Previously if user code was equal to null, then the accompanying show method would in effect call `null.show` which would crash the repl in a mysterious way.

Don't aggregate on dotty-repl in sbt script

dd17d1e

Address reviewer feedback

331892e

felixmulder force-pushed the topic/new-repl branch from 5964e04 to 331892e Compare August 23, 2017 15:50

felixmulder unassigned OlivierBlanvillain Aug 23, 2017

felixmulder changed the title ~~[WIP] Add native Dotty REPL~~ Add native Dotty REPL Aug 23, 2017

felixmulder assigned OlivierBlanvillain Aug 23, 2017

felixmulder requested a review from OlivierBlanvillain August 23, 2017 15:54

OlivierBlanvillain approved these changes Aug 23, 2017

View reviewed changes

felixmulder merged commit d70b8f4 into scala:master Aug 23, 2017

allanrenucci deleted the topic/new-repl branch December 14, 2017 19:25

smarter mentioned this pull request Jan 11, 2018

Forward-port REPL improvements #1087

Closed


		import dotc.reporting.MessageRendering

		/** Runs all tests contained withing `/repl/test-resources/scripts` */

Add native Dotty REPL #2991

Add native Dotty REPL #2991

Uh oh!

Conversation

felixmulder commented Aug 17, 2017

Uh oh!

OlivierBlanvillain commented Aug 23, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

OlivierBlanvillain left a comment

Choose a reason for hiding this comment

Uh oh!

rom1dep commented Aug 29, 2017

Uh oh!

felixmulder commented Aug 29, 2017

Uh oh!

Uh oh!