Add null-check to <id>Show method

Previously if user code was equal to null, then the accompanying show
method would in effect call `null.show` which would crash the repl in a
mysterious way.

Author: felixmulder

repl/src/dotty/tools/repl/ReplCompiler.scala

@@ -8,6 +8,7 @@ import dotc.ast.{ untpd, tpd }
 import dotc.{ Run, CompilationUnit, Compiler }
 import dotc.core.Decorators._, dotc.core.Flags._, dotc.core.Phases
 import dotc.core.Names._, dotc.core.Contexts._, dotc.core.StdNames._
+import dotc.core.Constants.Constant
 import dotc.util.SourceFile
 import dotc.typer.{ ImportInfo, FrontEnd }
 import backend.jvm.GenBCode
@@ -68,7 +69,13 @@ class ReplCompiler(val directory: AbstractFile) extends Compiler {
     def createShow(name: TermName, pos: Position) = {
       val showName = name ++ "Show"
       val select = Select(Ident(name), "show".toTermName)
-      DefDef(showName, Nil, Nil, TypeTree(), select).withFlags(Synthetic).withPos(pos)
+      val valAsAnyRef = TypeApply(Select(Ident(name), nme.asInstanceOf_),
+                                  List(Ident(tpnme.AnyRef)))
+      val cond = InfixOp(valAsAnyRef,
+                         Ident(nme.EQ),
+                         Literal(Constant(null)))
+      val showWithNullCheck = If(cond, Literal(Constant("null")), select)
+      DefDef(showName, Nil, Nil, TypeTree(), showWithNullCheck).withFlags(Synthetic).withPos(pos)
     }
 
     val (exps, other) = trees.partition(_.isTerm)
@@ -181,6 +188,8 @@ class ReplCompiler(val directory: AbstractFile) extends Compiler {
       defs  <- definitions(parsed.trees, state)
       unit  <- createUnit(defs, parsed.sourceCode)
       state <- runCompilation(unit, defs.state)
+      _ = println(unit.untpdTree.show(state.run.runContext))
+      _ = println(unit.tpdTree.show(state.run.runContext))
     } yield (unit, state)
   }
 

repl/test-resources/repl/renderNull

@@ -0,0 +1,2 @@
+scala> val x: String = null
+val x: String = null