Skip to content

Fix #3024: repl alias in sbt and dist/bin/dotr not working #3026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 29, 2017

Conversation

felixmulder
Copy link
Contributor

We should also decide if we should ditch the old ./bin scripts in favor of the ./dist/bin scripts. Keeping both up to date feels tedious.

@felixmulder felixmulder requested a review from liufengyun August 28, 2017 10:13
This was referenced Aug 29, 2017
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Regarding bin/dotc and bin/dotr, if nobody is using them, we can remove.

@rom1dep
Copy link

rom1dep commented Aug 29, 2017

I just discovered about ./dist/bin, it doesn't do anything here but printing errors about missing dotty/dist/lib/’.

If I had a vote for saving either, it would go to ./bin :)

@liufengyun
Copy link
Contributor

@rom1dep dist/bin is mainly for releasing Dotty packages. To try it, you need to first run sbt dist/pack then run dist/target/pack/bin/dotr.

For development, we usually run dotc from sbt, thus no script is needed for development.

@felixmulder felixmulder merged commit 3601214 into scala:master Aug 29, 2017
@rom1dep
Copy link

rom1dep commented Aug 29, 2017

OK, I've been having ./bin in my path for a while and was appreciating the convenience of it triggering a rebuild as required. As my sole contribution here consists of fiddling with dotty's repl a few times a week/month, that's indeed not a strong defense for the extra maintenance cost :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants