Add Scalac scanning to the Travis CI build #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No review yet, let's see what Travis has to say first. |
And silence some of the error messages we print so the build log doesn't go above 4MB (Travis' limit)
|
@DarkDimius proposed a better solution, where we use submodules in git -- once he's done setting it up, it should replace the travis before_install hook. |
|
Okay, green light. Review by @DarkDimius, @sjrd or @lrytz. Please also merge it afterwards. |
|
LGTM |
DarkDimius
added a commit
that referenced
this pull request
Feb 16, 2014
Add Scalac scanning to the Travis CI build
OlivierBlanvillain
pushed a commit
to OlivierBlanvillain/dotty
that referenced
this pull request
Dec 8, 2016
At issue is that the optimizer would eliminate closure classes completely, then neglect to eliminate those classes from the container's InnerClasses attribute. This breaks tooling which expects those entries to correspond to real classes. The code change is essentially mgarcia's - I minimized it and put the caches in perRunCaches, and added the test case which verifies that after being compiled under -optimise, there are no inner classes. Before/after: 7,8d6 < InnerClasses: < public final scala#22; //class A_1$$anonfun$f$1 37,45c35,40 < scala#21 = Utf8 A_1$$anonfun$f$1 < scala#22 = Class scala#21 // A_1$$anonfun$f$1 < scala#23 = Utf8 Code --- > scala#21 = Utf8 Code
OlivierBlanvillain
pushed a commit
to OlivierBlanvillain/dotty
that referenced
this pull request
Dec 12, 2016
At issue is that the optimizer would eliminate closure classes completely, then neglect to eliminate those classes from the container's InnerClasses attribute. This breaks tooling which expects those entries to correspond to real classes. The code change is essentially mgarcia's - I minimized it and put the caches in perRunCaches, and added the test case which verifies that after being compiled under -optimise, there are no inner classes. Before/after: 7,8d6 < InnerClasses: < public final scala#22; //class A_1$$anonfun$f$1 37,45c35,40 < scala#21 = Utf8 A_1$$anonfun$f$1 < scala#22 = Class scala#21 // A_1$$anonfun$f$1 < scala#23 = Utf8 Code --- > scala#21 = Utf8 Code
szymon-rd
added a commit
that referenced
this pull request
Dec 9, 2022
Revert "Render TOC only in docs"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the Scalac source code to the Travis build so the tests can parse it.