entry point finding #22
Conversation
not quite done yet, need to figure out how to best write `definitions.isArrayOfSymbol` (see scalac). for that, need to understand the `Type` classes in dotty.
|
build failures are expected for now on the |
|
@lrytz: sorry, Travis can't filter the PRs by target branch -- either all PRs are checked or none are. It won't build the backend branch though, so PRs are the only case when Travis will bother you. |
|
no problem :) |
|
Actually it will build all branches, indiscriminately. You can filter out branches "by hand" by using explicit tests in the script: It is also possible (and I recommend it), to disable builds for branches that do not have a |
Oh, my mistake. I did not realize you had "branches: only: master" in your |
|
ping @magarciaEPFL |
|
subsumed by #124 |
At issue is that the optimizer would eliminate closure classes completely, then neglect to eliminate those classes from the container's InnerClasses attribute. This breaks tooling which expects those entries to correspond to real classes. The code change is essentially mgarcia's - I minimized it and put the caches in perRunCaches, and added the test case which verifies that after being compiled under -optimise, there are no inner classes. Before/after: 7,8d6 < InnerClasses: < public final scala#22; //class A_1$$anonfun$f$1 37,45c35,40 < scala#21 = Utf8 A_1$$anonfun$f$1 < scala#22 = Class scala#21 // A_1$$anonfun$f$1 < scala#23 = Utf8 Code --- > scala#21 = Utf8 Code
At issue is that the optimizer would eliminate closure classes completely, then neglect to eliminate those classes from the container's InnerClasses attribute. This breaks tooling which expects those entries to correspond to real classes. The code change is essentially mgarcia's - I minimized it and put the caches in perRunCaches, and added the test case which verifies that after being compiled under -optimise, there are no inner classes. Before/after: 7,8d6 < InnerClasses: < public final scala#22; //class A_1$$anonfun$f$1 37,45c35,40 < scala#21 = Utf8 A_1$$anonfun$f$1 < scala#22 = Class scala#21 // A_1$$anonfun$f$1 < scala#23 = Utf8 Code --- > scala#21 = Utf8 Code
Backport "Fix CLA checks after domain change of CLA check server" to LTS
not quite done yet, need to figure out how to best write
definitions.isArrayOfSymbol(see scalac). for that, need tounderstand the
Typeclasses in dotty.review by @magarciaEPFL
that's the last contribution before my ski holidays - will be back to work on the backend on february 24