Travis CI #21
Merged
Travis CI #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review by @sjrd, if possible. |
|
Seems to be working -- once the patch is merged, it should start building on Travis. |
| @@ -0,0 +1,13 @@ | |||
| language: scala | |||
| script: | |||
| - sbt ++$TRAVIS_SCALA_VERSION clean update compile test | |||
There was a problem hiding this comment.
what does ++$TRAVIS_SCALA_VERSION do? where is it defined?
There was a problem hiding this comment.
It's defined by the Travis build to the current scala version, in case you use cross-compilation.
See this doc for the full explanation: http://docs.travis-ci.com/user/languages/scala/#Choosing-Scala-versions-to-test-against
|
lgtm |
|
Thanks @lrytz! |
VladUreche
pushed a commit
that referenced
this pull request
Feb 14, 2014
|
got it. could we have travis pick up the scala version defined in |
|
Yes, let's do that. I'll make the changes in-place. |
OlivierBlanvillain
pushed a commit
to OlivierBlanvillain/dotty
that referenced
this pull request
Dec 8, 2016
At issue is that the optimizer would eliminate closure classes completely, then neglect to eliminate those classes from the container's InnerClasses attribute. This breaks tooling which expects those entries to correspond to real classes. The code change is essentially mgarcia's - I minimized it and put the caches in perRunCaches, and added the test case which verifies that after being compiled under -optimise, there are no inner classes. Before/after: 7,8d6 < InnerClasses: < public final scala#22; //class A_1$$anonfun$f$1 37,45c35,40 < scala#21 = Utf8 A_1$$anonfun$f$1 < scala#22 = Class scala#21 // A_1$$anonfun$f$1 < scala#23 = Utf8 Code --- > scala#21 = Utf8 Code
OlivierBlanvillain
pushed a commit
to OlivierBlanvillain/dotty
that referenced
this pull request
Dec 12, 2016
At issue is that the optimizer would eliminate closure classes completely, then neglect to eliminate those classes from the container's InnerClasses attribute. This breaks tooling which expects those entries to correspond to real classes. The code change is essentially mgarcia's - I minimized it and put the caches in perRunCaches, and added the test case which verifies that after being compiled under -optimise, there are no inner classes. Before/after: 7,8d6 < InnerClasses: < public final scala#22; //class A_1$$anonfun$f$1 37,45c35,40 < scala#21 = Utf8 A_1$$anonfun$f$1 < scala#22 = Class scala#21 // A_1$$anonfun$f$1 < scala#23 = Utf8 Code --- > scala#21 = Utf8 Code
WojciechMazur
added a commit
to WojciechMazur/dotty
that referenced
this pull request
Mar 19, 2025
Backport "Use bash shell when using here-strings" to LTS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Travis CI setup.