Skip to content

Modularize the rewrite rules (move out those that don’t produce semantically equivalent code) #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
julienrf opened this issue Jun 22, 2018 · 0 comments · Fixed by #72
Closed

Modularize the rewrite rules (move out those that don’t produce semantically equivalent code) #56

julienrf opened this issue Jun 22, 2018 · 0 comments · Fixed by #72
Milestone
Week 26

Comments

@julienrf
Copy link
Contributor

So that users can have fine-grained control on which rules to apply if they want to. In particular, one possibly controversial migration is the replacement of Stream with LazyList, since they can produce different behaviors. We should isolate the “Stream => LazyList” rule (we can just name it StreamToLazyList).

See the related discussion here: scala/collection-strawman#528 (comment)
@julienrf julienrf mentioned this issue Jun 22, 2018
Closed
@julienrf julienrf added this to the 2.13.0-M5 milestone Jun 22, 2018
@julienrf julienrf changed the title Modularize the rewrite rules Modularize the rewrite rules (move out those that don’t produce semantically equivalent code) Jun 25, 2018
This was referenced Jun 25, 2018
Merged
Merged
@MasseGuillaume MasseGuillaume mentioned this issue Jun 27, 2018
Closed
MasseGuillaume added a commit to MasseGuillaume/scala-collection-compat that referenced this issue Jun 28, 2018
@MasseGuillaume
Rewrite: Move LazyList and Map.mapValue rules to separate rules (fix s…
5dada85 
…cala#56)
MasseGuillaume added a commit to MasseGuillaume/scala-collection-compat that referenced this issue Jun 28, 2018
@MasseGuillaume
Move LazyList and Map.mapValue rules to separate rules (fix scala#56)
3bcbead
@MasseGuillaume MasseGuillaume mentioned this issue Jun 28, 2018
Merged
MasseGuillaume added a commit to MasseGuillaume/scala-collection-compat that referenced this issue Jun 29, 2018
@MasseGuillaume
Move LazyList and Map.mapValue rules to separate rules (fix scala#56)
4d94ab7
julienrf added a commit that referenced this issue Jun 29, 2018
@julienrf
Merge pull request #72 from MasseGuillaume/cross
a4f7b08 
Major Rewrite refactor: fix #19, fix #56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Week 26
Development

Successfully merging a pull request may close this issue.

Major Rewrite refactor: fix #19, fix #56 MasseGuillaume/scala-collection-compat
1 participant
@julienrf