Major Rewrite refactor: fix #19, fix #56 #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MasseGuillaume
changed the title
CrossCompat migration rule that produces code which cross-compiles with 2.12- (fix#19)Stable212 migration rule that produces code which cross-compiles with 2.12- (fix#19)
MasseGuillaume
changed the title
Stable212 migration rule that produces code which cross-compiles with 2.12- (fix#19)CrossCompat migration rule that produces code which cross-compiles with 2.12- (fix#19)
MasseGuillaume
commented
Jun 28, 2018
|
|
||
|
|
||
|
|
||
| package fix |
There was a problem hiding this comment.
@julienrf 🎉 cross-compatible CanBuildFrom migration.
MasseGuillaume
changed the title
CrossCompat migration rule that produces code which cross-compiles with 2.12- (fix#19)
MasseGuillaume
changed the title
since rules are split accross multiple files it's not possible to use GitHub to publish te rule. We need to publish on maven central: scala#73
|
@julienrf this one is good to go. Let's review it together. |
julienrf
reviewed
Jun 29, 2018
CONTRIBUTING.md
Outdated
| @@ -29,18 +29,18 @@ Even better, instead of providing a diff, you can directly add it as a test case | |||
|
|
|||
| 1. Fork this repository and create a separate branch; | |||
|
|
|||
| 2. Add a file in the `scalafix/input/src/main/scala/fix/` directory with code | |||
| 2. Add a file in the `scalafix-input/src/main/scala/fix/` directory with code | |||
There was a problem hiding this comment.
You should fix these references too
MasseGuillaume
force-pushed
the
cross
branch
2 times, most recently
from
a4c592a to
4d35a8b
Compare
|
@MasseGuillaume The CI fails with this error: “sbt.ResolveException: unresolved dependency: org.scalameta#semanticdb-scalac_2.12.6;2.1.7: not found” |
MasseGuillaume
force-pushed
the
cross
branch
9 times, most recently
from
7647467 to
3ed436c
Compare
MasseGuillaume
force-pushed
the
cross
branch
5 times, most recently
from
814f584 to
6d2925d
Compare
martijnhoekstra
pushed a commit
to martijnhoekstra/scala-collection-compat
that referenced
this pull request
Nov 9, 2022
fix bad artifacts by disabling OSGi support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CrossCompatmigration rule that produces code which cross-compiles with 2.12 (fix AddCrossCompatmigration rule that produces code which cross-compiles with 2.12- #19)