Skip to content

Move scalafix build to the main build #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

MasseGuillaume
Copy link
Contributor

In preparation for #56.

We want to split scalafix into multiple rules. The current distribution on GitHub does not allow us to share code between rules, they need to be a single file. We need to set up publishing on maven central for this.

))

disablePlugins(JvmPlugin)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this prevents sbt from giving command history / autocompletion.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference, this was added in #41

@@ -19,14 +19,14 @@ set -e
RELEASE_COMBO=true

if [[ "$TEST_SCALAFIX" == "true" ]]; then
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RELEASE_COMBO does not seem to be used.

lazy val input = project
.in(file("scalafix/input"))
.settings(
scalaVersion := scalafixScala212,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

semanticdb plugin required by scalafix is not available for 2.12.6

@MasseGuillaume
Copy link
Contributor Author

/cc @lrytz would it be possible to setup scalafix rules for publishing on maven central. I don't want to disrupt the current publishing infrastructure.

martijnhoekstra pushed a commit to martijnhoekstra/scala-collection-compat that referenced this pull request Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants