codegen: Reuse the next_child_local_id hack for template instantiations. #708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @fitzgen |
This should be good enough, following the pattern of anonymous items, and should prevent most of the current noise in stylo updates. Closes rust-lang#620 Fixes rust-lang#619
emilio
force-pushed
the
template-inst-noise
branch
from
cc45375 to
44f6858
Compare
|
This works, but uses the parent item which is not great. I could use the template definition, which would need resolving through typerefs and all that. That'd produce better results I think, but it's not clear if it's worth. Whatever you prefer, @fitzgen |
|
@bors-servo r+ |
|
📌 Commit 44f6858 has been approved by |
|
☀️ Test successful - status-travis |
|
This is still pretty painful, because some template types are used widely (e.g. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be good enough, following the pattern of anonymous items, and should
prevent most of the current noise in stylo updates.
Closes #620
Fixes #619