[WIP] Template instantiation layout test name mangling #620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit defines a new set of assertion macros that are only checked in testing/CI when the `testing_only_extra_assertions` feature is enabled. This makes it so that *users* of bindgen that happen to be making a debug build don't enable all these extra and expensive assertions. Additionally, this removes the `testing_only_assert_no_dangling_items` feature, and runs the assertions that were previously gated on that feature when the new `testing_only_extra_assertions` feature is enabled.
This replaces various `unwrap` calls with `expect` calls that have better diagnostic messages if/when they fail.
|
☔ The latest upstream changes (presumably #621) made this pull request unmergeable. Please resolve the merge conflicts. |
|
I suspect the "completely instantiated template" check may not work as greatly for non-functions? |
|
Can we give this a higher priority? It is pretty painful to land patches when you push the numbers a bit via including a new file... |
|
I don't personally have the cycles to work on this. Feel free to take over. |
emilio
added a commit
to emilio/rust-bindgen
that referenced
this pull request
May 19, 2017
This should be good enough, following the pattern of anonymous items, and should prevent most of the current noise in stylo updates. Closes rust-lang#620 Fixes rust-lang#619
|
I put some other approach to this in #708 |
emilio
added a commit
to emilio/rust-bindgen
that referenced
this pull request
May 20, 2017
This should be good enough, following the pattern of anonymous items, and should prevent most of the current noise in stylo updates. Closes rust-lang#620 Fixes rust-lang#619
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
work in progress fix for #619
It seems we aren't ever getting the mangled name out of libclang for template instantiations in practice, so we're hitting the fallback behavior (master's current behavior) 100% of the time :-/
Someone feel free to steal this from me, I'm not planning on investigating further in the near future.