Skip to content

Generate more consistent-across-bindings-generation names for template instantiation layout tests #619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fitzgen opened this issue Apr 7, 2017 · 1 comment
Closed

Generate more consistent-across-bindings-generation names for template instantiation layout tests #619

fitzgen opened this issue Apr 7, 2017 · 1 comment

Comments

@fitzgen
Copy link
Member

fitzgen commented Apr 7, 2017

Right now, we generate names like __bindgen_test_layout_Rooted_instantiation_106.

We could instead use the C++ mangled name, or some other name mangling of our own choosing, rather than appending the ItemId to the test name. The ItemId is rather inconsistent across bindings generations, which causes unnecessary diff noise.

cc @upsuper
@fitzgen
Copy link
Member Author

fitzgen commented Apr 7, 2017

I have a WIP patch, will put it up in a second

@fitzgen fitzgen mentioned this issue Apr 7, 2017
Closed
emilio added a commit to emilio/rust-bindgen that referenced this issue May 19, 2017
@emilio
codegen: Reuse the next_child_local_id hack for template instantiations.
cc45375 
This should be good enough, following the pattern of anonymous items, and should
prevent most of the current noise in stylo updates.

Closes rust-lang#620
Fixes rust-lang#619
@emilio emilio mentioned this issue May 19, 2017
Merged
emilio added a commit to emilio/rust-bindgen that referenced this issue May 20, 2017
@emilio
codegen: Reuse the next_child_local_id hack for template instantiations.
44f6858 
This should be good enough, following the pattern of anonymous items, and should
prevent most of the current noise in stylo updates.

Closes rust-lang#620
Fixes rust-lang#619
bors-servo pushed a commit that referenced this issue May 20, 2017
Auto merge of #708 - emilio:template-inst-noise, r=fitzgen
ea9a932 
codegen: Reuse the next_child_local_id hack for template instantiations.

This should be good enough, following the pattern of anonymous items, and should
prevent most of the current noise in stylo updates.

Closes #620
Fixes #619
emilio added a commit to emilio/servo that referenced this issue May 21, 2017
@emilio
style: Bump bindgen version.
45799f6 
This should fix bug 1365488, and also the template instantiation test noise
reported at rust-lang/rust-bindgen#619.
@emilio emilio mentioned this issue May 21, 2017
Merged
emilio added a commit to emilio/servo that referenced this issue May 21, 2017
@emilio
style: Bump bindgen version.
6b5beb3 
This should fix bug 1365488, and also the template instantiation test noise
reported at rust-lang/rust-bindgen#619.
bors-servo pushed a commit to servo/servo that referenced this issue May 21, 2017
Auto merge of #16975 - emilio:bindgenupagain, r=upsuper
1602edb 
style: Bump bindgen version.

This should fix bug 1365488, and also the template instantiation test noise
reported at rust-lang/rust-bindgen#619.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16975)
<!-- Reviewable:end -->
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue May 21, 2017
@emilio
servo: Merge #16975 - style: Bump bindgen version (from emilio:bindge…
7c79fdb 
…nupagain); r=upsuper

This should fix bug 1365488, and also the template instantiation test noise
reported at rust-lang/rust-bindgen#619.

Source-Repo: https://github.com/servo/servo
Source-Revision: 1602edb04ac3cc06a71eb6349e137dce453bc191

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 06b0a5c0055788959826d228b5d1ebd7764d43c9
aethanyc pushed a commit to aethanyc/gecko-dev that referenced this issue May 22, 2017
@emilio
servo: Merge #16975 - style: Bump bindgen version (from emilio:bindge…
ec19cca 
…nupagain); r=upsuper

This should fix bug 1365488, and also the template instantiation test noise
reported at rust-lang/rust-bindgen#619.

Source-Repo: https://github.com/servo/servo
Source-Revision: 1602edb04ac3cc06a71eb6349e137dce453bc191
JerryShih pushed a commit to JerryShih/gecko-dev that referenced this issue May 25, 2017
@emilio
servo: Merge #16975 - style: Bump bindgen version (from emilio:bindge…
a679e1b 
…nupagain); r=upsuper

This should fix bug 1365488, and also the template instantiation test noise
reported at rust-lang/rust-bindgen#619.

Source-Repo: https://github.com/servo/servo
Source-Revision: 1602edb04ac3cc06a71eb6349e137dce453bc191
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Oct 1, 2019
@marco-c
servo: Merge #16975 - style: Bump bindgen version (from emilio:bindge…
5ee112e 
…nupagain); r=upsuper

This should fix bug 1365488, and also the template instantiation test noise
reported at rust-lang/rust-bindgen#619.

Source-Repo: https://github.com/servo/servo
Source-Revision: 1602edb04ac3cc06a71eb6349e137dce453bc191

UltraBlame original commit: e3efc7fb48dfc56b7f82ee5cfc4c316c6c60a0bf
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Oct 1, 2019
@marco-c
servo: Merge #16975 - style: Bump bindgen version (from emilio:bindge…
daf95a0 
…nupagain); r=upsuper

This should fix bug 1365488, and also the template instantiation test noise
reported at rust-lang/rust-bindgen#619.

Source-Repo: https://github.com/servo/servo
Source-Revision: 1602edb04ac3cc06a71eb6349e137dce453bc191

UltraBlame original commit: e3efc7fb48dfc56b7f82ee5cfc4c316c6c60a0bf
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Oct 1, 2019
@marco-c
servo: Merge #16975 - style: Bump bindgen version (from emilio:bindge…
f223e79 
…nupagain); r=upsuper

This should fix bug 1365488, and also the template instantiation test noise
reported at rust-lang/rust-bindgen#619.

Source-Repo: https://github.com/servo/servo
Source-Revision: 1602edb04ac3cc06a71eb6349e137dce453bc191

UltraBlame original commit: e3efc7fb48dfc56b7f82ee5cfc4c316c6c60a0bf
bhearsum pushed a commit to mozilla-releng/staging-firefox that referenced this issue May 1, 2025
@emilio
servo: Merge #16975 - style: Bump bindgen version (from emilio:bindge…
2a0a8e4 
…nupagain); r=upsuper

This should fix bug 1365488, and also the template instantiation test noise
reported at rust-lang/rust-bindgen#619.

Source-Repo: https://github.com/servo/servo
Source-Revision: 1602edb04ac3cc06a71eb6349e137dce453bc191
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fitzgen