-
Notifications
You must be signed in to change notification settings - Fork 746
Use iterators for comment children, attributes, etc. #166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
cc @fitzgen |
Hello, Would it be reasonable to follow the accepted answer here as a guide? |
Sure, it'd be great! Yeah, that answer seems pretty reasonable :) |
Does this issue make #143 redundant? |
Agh, sort of, I didn't read this comment soon enough. That being said, another contributor had already made progress in that issue, so I think that should be merged. If you could rebase your patch on top of it (should be straight-forward), that would be great :) |
Yes, that should not be an issue as soon as it is available in master. |
It's easier, more efficient, and more readable than all the bound-checking we're doing, specially taking into account that each bound check is an extra ffi call.
The text was updated successfully, but these errors were encountered: