Use iterators for comment children and attributes fix #166 #169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jeanphilippeD
changed the title
jeanphilippeD
force-pushed
the
issue166
branch
2 times, most recently
from
6a4ddeb to
9e8bae7
Compare
emilio
approved these changes
Oct 30, 2016
| unsafe { | ||
| String_ { x: clang_HTMLStartTag_getAttrName(self.x, idx) }.to_string() | ||
| /// An iterator for a comment's children | ||
| pub struct CommentChildrenIntoIterator { |
There was a problem hiding this comment.
nit: Probably CommentChildrenIterator? IntoIterator usually means that it "consumes" the value, which doesn't make a lot of sense in this case.
| } | ||
|
|
||
| /// An iterator for a comment's attributes | ||
| pub struct CommentAttributesIntoIterator { |
There was a problem hiding this comment.
Same, CommentAttributesIterator seems like a better name for this, since it doesn't consume the comment.
| name: String_ { x: unsafe { clang_HTMLStartTag_getAttrName(self.x, idx) } }.to_string(), | ||
| value: String_ { x: unsafe { clang_HTMLStartTag_getAttrValue(self.x, idx) } }.to_string() | ||
| }) | ||
| } |
There was a problem hiding this comment.
nit: Rust style is } else {.
jeanphilippeD
force-pushed
the
issue166
branch
from
9e8bae7 to
daabd07
Compare
|
Thanks for the review. |
|
☔ The latest upstream changes (presumably #158) made this pull request unmergeable. Please resolve the merge conflicts. |
jeanphilippeD
force-pushed
the
issue166
branch
from
daabd07 to
91eb86d
Compare
|
@bors-servo r+ Neat, thanks! |
|
📌 Commit 91eb86d has been approved by |
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #166