Skip to content

clang::Comment::get_tag_attr_{name,value} should bounds check their idx parameter #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fitzgen opened this issue Oct 25, 2016 · 1 comment
Closed

clang::Comment::get_tag_attr_{name,value} should bounds check their idx parameter #143

fitzgen opened this issue Oct 25, 2016 · 1 comment
Labels
E-easy I-cleanup

Comments

@fitzgen
Copy link
Member

fitzgen commented Oct 25, 2016

They should check that idx <= self.get_num_tag_attrs() and return None if idx is out of bounds, otherwise proceed as they do now and return Some.

This is one less foot gun for callers using this method.

I can mentor whoever would like to work on this.
@highfive
Copy link

Please make a comment here if you intend to work on this issue. Thank you!

@ajnirp ajnirp mentioned this issue Oct 29, 2016
Merged
@jeanphilippeD jeanphilippeD mentioned this issue Oct 30, 2016
Closed
bors-servo pushed a commit that referenced this issue Oct 30, 2016
Auto merge of #158 - ajnirp:143-comment-get-tag-attr, r=emilio
9db4d1f 
143 comment get tag attr

Fixes #143
bors-servo pushed a commit that referenced this issue Oct 31, 2016
Auto merge of #158 - ajnirp:143-comment-get-tag-attr, r=emilio
ebfa083 
143 comment get tag attr

Fixes #143
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-easy I-cleanup
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fitzgen @highfive