Clippy and const and &'static references

[martinthomson]

Input C/C++ Header

#define X "string"

Bindgen Invocation

I don't think that I've tweaked anything here.

Actual Results

pub const X: &'static [u8; 2usize] = b"string\0";

This results in warnings from clippy when compiled with #![deny(warnings)]. The use of &'static trips clippy::redundant_static_lifetimes.

Expected Results

As explained in the lint, the use of &'static is redundant and can be removed.

[Lokathor]

I was just about to open this issue myself <3

[emilio]

Is it redundant in all the rust versions that bindgen supports? I'm not sure we intentionally keep our generated code clippy-warning-free, but improvements are welcome of course.

[Lokathor]

Clearly the generated module should simply insert

#![allow(clippy::redundant_static_lifetimes)]

If you're targeting a rust version that allows tool attributes :P

But more seriously, the 'static can probably be skipped if the target rust version is new enough.

looking through the releases file, seems like 1.17 made the change here https://github.com/rust-lang/rust/blob/master/RELEASES.md#version-1170-2017-04-27

[emilio]

Ok, we could add a rust-target for 1.17 and just not emit the &'static if the rust target version is greater than that.

[wucke13]

I was about to open this issue and then found it already here. Is this still considered a TODO?