Drop 'static for pub const strings

Constant and static declaration have a 'static live time by default,
that is already elided since 1.17.

Clippy complains on this kind of strings that are present in the
generated code.

This patch remove the 'static live time for those strings.

Fix rust-lang#1612

Signed-off-by: Alberto Planas <[email protected]>

Author: aplanas

src/codegen/mod.rs

@@ -668,7 +668,7 @@ impl CodeGenerator for Var {
                             let cstr = helpers::ast_ty::cstr_expr(string);
                             result.push(quote! {
                                 #(#attrs)*
-                                pub const #canonical_ident : &'static #ty = #cstr ;
+                                pub const #canonical_ident : &#ty = #cstr ;
                             });
                         }
                         Err(..) => {

tests/expectations/tests/libclang-3.9/constant-evaluate.rs

@@ -23,5 +23,5 @@ pub const BAZ: ::std::os::raw::c_longlong = 24;
 pub const fuzz: f64 = 51.0;
 pub const BAZZ: ::std::os::raw::c_char = 53;
 pub const WAT: ::std::os::raw::c_char = 0;
-pub const bytestring: &'static [u8; 4usize] = b"Foo\0";
+pub const bytestring: &[u8; 4usize] = b"Foo\0";
 pub const NOT_UTF8: [u8; 5usize] = [240u8, 40u8, 140u8, 40u8, 0u8];

tests/expectations/tests/libclang-4/constant-evaluate.rs

@@ -21,5 +21,5 @@ pub const BAZ: ::std::os::raw::c_longlong = 24;
 pub const fuzz: f64 = 51.0;
 pub const BAZZ: ::std::os::raw::c_char = 53;
 pub const WAT: ::std::os::raw::c_char = 0;
-pub const bytestring: &'static [u8; 4usize] = b"Foo\0";
+pub const bytestring: &[u8; 4usize] = b"Foo\0";
 pub const NOT_UTF8: [u8; 5usize] = [240u8, 40u8, 140u8, 40u8, 0u8];

tests/expectations/tests/libclang-5/constant-evaluate.rs

@@ -21,5 +21,5 @@ pub const BAZ: ::std::os::raw::c_longlong = 24;
 pub const fuzz: f64 = 51.0;
 pub const BAZZ: ::std::os::raw::c_char = 53;
 pub const WAT: ::std::os::raw::c_char = 0;
-pub const bytestring: &'static [u8; 4usize] = b"Foo\0";
+pub const bytestring: &[u8; 4usize] = b"Foo\0";
 pub const NOT_UTF8: [u8; 5usize] = [240u8, 40u8, 140u8, 40u8, 0u8];

tests/expectations/tests/libclang-9/constant-evaluate.rs

@@ -21,5 +21,5 @@ pub const BAZ: ::std::os::raw::c_longlong = 24;
 pub const fuzz: f64 = 51.0;
 pub const BAZZ: ::std::os::raw::c_char = 53;
 pub const WAT: ::std::os::raw::c_char = 0;
-pub const bytestring: &'static [u8; 4usize] = b"Foo\0";
+pub const bytestring: &[u8; 4usize] = b"Foo\0";
 pub const NOT_UTF8: [u8; 5usize] = [240u8, 40u8, 140u8, 40u8, 0u8];

tests/expectations/tests/macro_const.rs

@@ -5,7 +5,7 @@
     non_upper_case_globals
 )]
 
-pub const foo: &'static [u8; 4usize] = b"bar\0";
+pub const foo: &[u8; 4usize] = b"bar\0";
 pub const CHAR: u8 = 98u8;
 pub const CHARR: u8 = 0u8;
 pub const FLOAT: f64 = 5.09;