Drop 'static for pub const strings

[aplanas]

Constant and static declaration have a 'static live time by default,
that is already elided since 1.17.

Clippy complains on this kind of strings that are present in the
generated code.

This patch remove the 'static live time for those strings.

Fix #1612

Signed-off-by: Alberto Planas [email protected]

[emilio]

This looks good (sorry for the lag) but it probably needs a little more work. In particular, we claim to support 1.0-compatible code (see src/features.rs).

At this point, we might get away with breaking that and supporting 1.19+ only, but it might also be worth just adding a RustTarget::Stable_1_17 and check for it.

[aplanas]

@emilio Oh I see! Instead of removing RustTarget::Stable_1_0 I removed RustTarget::Stable_1_1 (as seems empty feature-wise) and added RustTarget::Stable_1_17 and a test to cover the old 1.0 behavior where &'static lifetime was added.

Of course, another change is that mod.rs now checks for the static_lifetime_elision feature.

[aplanas]

@emilio Do you see any missing bits in the PR? Maybe you prefer to drop Rust 1.0 support, or improve the tests?

[emilio]

No, sorry, I've just been busy with work and it always takes some mental space to page stuff back in. Looks great, thanks!