Skip to content

Our C-Smith driver should ask bindgen to derive everything #1037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fitzgen opened this issue Sep 25, 2017 · 7 comments
Closed

Our C-Smith driver should ask bindgen to derive everything #1037

fitzgen opened this issue Sep 25, 2017 · 7 comments
Labels
A-csmith A-testing C-assigned E-easy enhancement hacktoberfest help wanted

Comments

@fitzgen
Copy link
Member

fitzgen commented Sep 25, 2017

Might as well cover all the bases...

See csmith-fuzzing/driver.py. The run_bindgen function should pass all the derive-enabling command line flags listed via bindgen --help.
@highfive
Copy link

Hi! If you have any questions regarding this issue, feel free to make a comment here, or ask it in the #servo channel in IRC.

If you intend to work on this issue, then add @highfive: assign me to your comment, and I'll assign this to you. 😄

@fitzgen fitzgen mentioned this issue Sep 25, 2017
Merged
@clippered
Copy link
Contributor

looks pretty straightforward as my first work :)
@highfive: assign me

@highfive
Copy link

Hey @clippered! Thanks for your interest in working on this issue. It's now assigned to you!

clippered added a commit to clippered/rust-bindgen that referenced this issue Sep 27, 2017
@clippered
Issue rust-lang#1037: pass all derive-enabling flags in bindgen for c…
225c9a4 
…smith driver
@fitzgen
Copy link
Member Author

fitzgen commented Sep 28, 2017

Let me know if you run into any questions @clippered :)

bors-servo pushed a commit that referenced this issue Sep 28, 2017
Auto merge of #1043 - clippered:issue-1037/csmith_driver_derive, r=fi…
e350477 
…tzgen

Issue #1037: pass all derive-enabling flags in bindgen for csmith driver

r? @fitzgen
fitzgen added a commit that referenced this issue Sep 29, 2017
@fitzgen
Merge pull request #1043 from clippered/issue-1037/csmith_driver_derive
c160b20 
Issue #1037: pass all derive-enabling flags in bindgen for csmith driver
@clippered
Copy link
Contributor

@fitzgen Should this be closed now that #1043 has been merged? Thanks

@fitzgen
Copy link
Member Author

fitzgen commented Oct 12, 2017

Yes, thanks! In the future, if you add Fixes #12345 to commit messages, then github will auto close them :)

@fitzgen fitzgen closed this as completed Oct 12, 2017
@clippered
Copy link
Contributor

Will do it next time, cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-csmith A-testing C-assigned E-easy enhancement hacktoberfest help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@fitzgen @Manishearth @clippered @highfive