Skip to content

Csmith tweaks #1035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 25, 2017
Merged

Csmith tweaks #1035

merged 2 commits into from
Sep 25, 2017

Conversation

fitzgen
Copy link
Member

@fitzgen fitzgen commented Sep 25, 2017

r? @e00E or @emilio or @pepyakin whoever wants to get here first ;)

This allows us to have multiple processes generating C files with C-Smith and
testing them on bindgen without stepping on each others' toes.
This makes us fall over flat on our faces almost immediately...
Copy link
Contributor

@pepyakin pepyakin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. Though I'm not an python expert

return run_logged([
"bindgen",
"--with-derive-partialeq",
"--with-derive-eq",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should use all of the --with-derive to improve coverage?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll file a follow up :)

@fitzgen
Copy link
Member Author

fitzgen commented Sep 25, 2017

@bors-servo r=pepyakin

@bors-servo
Copy link

📌 Commit ba2db57 has been approved by pepyakin

@bors-servo
Copy link

⌛ Testing commit ba2db57 with merge c797010...

bors-servo pushed a commit that referenced this pull request Sep 25, 2017
Csmith tweaks

r? @e00E or @emilio or @pepyakin whoever wants to get here first ;)
@fitzgen
Copy link
Member Author

fitzgen commented Sep 25, 2017

Thanks for review! :)

@fitzgen
Copy link
Member Author

fitzgen commented Sep 25, 2017

Filed #1037

@bors-servo
Copy link

☀️ Test successful - status-travis
Approved by: pepyakin
Pushing c797010 to master...

@bors-servo bors-servo merged commit ba2db57 into rust-lang:master Sep 25, 2017
@fitzgen fitzgen deleted the csmith-tweaks branch September 25, 2017 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants