Skip to content

Issue #1037: pass all derive-enabling flags in bindgen for csmith driver #1043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 29, 2017

Conversation

clippered
Copy link
Contributor

@highfive
Copy link

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @fitzgen (or someone else) soon.

Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks!

@fitzgen
Copy link
Member

fitzgen commented Sep 28, 2017

@bors-servo r+

@bors-servo
Copy link

📌 Commit 225c9a4 has been approved by fitzgen

@bors-servo
Copy link

⌛ Testing commit 225c9a4 with merge e350477...

bors-servo pushed a commit that referenced this pull request Sep 28, 2017
…tzgen

Issue #1037: pass all derive-enabling flags in bindgen for csmith driver

r? @fitzgen
@bors-servo
Copy link

💔 Test failed - status-travis

@clippered
Copy link
Contributor Author

looks like it fails in building rustfmt-nightly in CI. so does it need a re-run?

@fitzgen
Copy link
Member

fitzgen commented Sep 29, 2017

looks like it fails in building rustfmt-nightly in CI. so does it need a re-run?

I think it was rust-lang/rustfmt#2002, which now appears to be fixed. I'll go ahead and merge this manually though.

Sorry for the hiccup!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants