Use django-storages' manifest files class instead of the overriden class

[dogukanteber]

Hopefully resolves #8773

[astrojuanlu]

Thanks for your contribution @dogukanteber ! We will have a look at it shortly

[humitos]

Thanks for your PR. I added some comments that need to be addressed before moving forward.

[dogukanteber]

Thank you for your comments @humitos. I will make the requested changes.

[humitos]

This looks good to me! Thanks @dogukanteber! We should be able to merge this PR and tested locally by running collectstatic 💪🏼

[dogukanteber]

@humitos I guess something went wrong during CircleCI tests. I have been waiting the tests results for half an hour but nothing came up. So I took a look at the details and saw this error message:

sphinx-18 create: /home/circleci/project/.tox/sphinx-18
sphinx-18 installdeps: Sphinx~=1.8.0
ERROR: Got SIGTERM, handling it as a KeyboardInterrupt
ERROR: got KeyboardInterrupt signal


Too long with no output (exceeded 10m0s): context deadline exceeded

Did I cause this error? If not, can we rerun the tests?

[humitos]

@dogukanteber I'm not sure what's happening with CircleCI. I'm having the same problem with my PRs and I wasn't able to fix it yet. @stsewd do you know what it could be?

[stsewd]

@dogukanteber I'm not sure what's happening with CircleCI. I'm having the same problem with my PRs and I wasn't able to fix it yet. @stsewd do you know what it could be?

nope

[dogukanteber]

Hello @humitos. Any improvements about the PR?

[humitos]

I think the problem with CircleCI was an issue with pip. I re-triggered the tests to be run again. Let's see how it goes. If that does not work, you could rebase this PR against master or merge master into it.

[dogukanteber]

I have merged master into this branch @humitos. It seems the previous error is disappeared. However, there is a Pylint error that says pylint: too-many-ancestors / Too many ancestors (9/7). I did not want to sweep under the rug just to get rid of the error. I'd like to get your opinion on this. How should we proceed?

[humitos]

😓 --you can disable that error by adding a comment right next the class definition:

class S3...(.., ..):  # pylint: disable=too-many-ancestors

[dogukanteber]

I saw that coming. Now it says E501 / line too long (124 > 100 characters). I do not how to get around this error without removing the pylint error @humitos.

[humitos]

You can use

class MyClass(
   AnotherClass,
   AnotherClassExtra,
   ...
):

to avoid the line to be too long.

[dogukanteber]

I suppose, I finally did it @humitos. I hope we can merge this in.

[humitos]

Yeaahhh! Awesome! Thank you so much! 💪