Use django-storages' manifest files class instead of the overriden class

Author: dogukanteber

readthedocs/settings/docker_compose.py

@@ -155,7 +155,7 @@ def show_debug_toolbar(request):
     # Storage backend for build languages
     RTD_BUILD_TOOLS_STORAGE = 'readthedocs.storage.s3_storage.S3BuildToolsStorage'
     # Storage for static files (those collected with `collectstatic`)
-    STATICFILES_STORAGE = 'readthedocs.storage.s3_storage.S3StaticStorage'
+    STATICFILES_STORAGE = 'storages.backends.s3boto3.S3ManifestStaticStorage'
 
     AWS_ACCESS_KEY_ID = 'admin'
     AWS_SECRET_ACCESS_KEY = 'password'

readthedocs/storage/s3_storage.py

@@ -19,23 +19,6 @@
 from .mixins import OverrideHostnameMixin, S3PrivateBucketMixin
 
 
-class S3BuildMediaStorage(BuildMediaStorageMixin, OverrideHostnameMixin, S3Boto3Storage):
-
-    """An AWS S3 Storage backend for build artifacts."""
-
-    bucket_name = getattr(settings, 'S3_MEDIA_STORAGE_BUCKET', None)
-    override_hostname = getattr(settings, 'S3_MEDIA_STORAGE_OVERRIDE_HOSTNAME', None)
-
-    def __init__(self, *args, **kwargs):
-        super().__init__(*args, **kwargs)
-
-        if not self.bucket_name:
-            raise ImproperlyConfigured(
-                'AWS S3 not configured correctly. '
-                'Ensure S3_MEDIA_STORAGE_BUCKET is defined.',
-            )
-
-
 class S3BuildCommandsStorage(S3PrivateBucketMixin, S3Boto3Storage):
 
     """An AWS S3 Storage backend for build commands."""