Skip to content

Use django-storages's manifest files class #8773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
humitos opened this issue Dec 20, 2021 · 0 comments · Fixed by #8781
Closed

Use django-storages's manifest files class #8773

humitos opened this issue Dec 20, 2021 · 0 comments · Fixed by #8781
Labels
Accepted Accepted issue on our roadmap Good First Issue Good for new contributors Improvement Minor improvement to code
Milestone

Comments

@humitos
Copy link
Member

humitos commented Dec 20, 2021

django-storages already implemented the manifest files class (see jschneier/django-storages#733 (comment)) so we can use it directly and remove our override for this in:

class S3StaticStorage(OverrideHostnameMixin, ManifestFilesMixin, S3Boto3Storage):
"""
An AWS S3 Storage backend for static media.
* Uses Django's ManifestFilesMixin to have unique file paths (eg. core.a6f5e2c.css)
"""

@humitos humitos added Good First Issue Good for new contributors Improvement Minor improvement to code Accepted Accepted issue on our roadmap labels Dec 20, 2021
@humitos humitos added this to the Refactoring milestone Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Good First Issue Good for new contributors Improvement Minor improvement to code
Projects
None yet
1 participant