Add separate version create view and create view URL

[agjohnson]

This is not currently used outside the new theme, but enables the
solution for #6238 -- latest master of the new theme already expects
this code.

For now, the create URL does throw and exception, because we are
rendering template code inside the version form. I'm not going to
address this as the create view is not linked and unused, and we
probably shouldn't be rendering templates inside form instantiation
anyways.

The edit version URL does change with this, to append the /edit/
postfix. This was done to match similar URL patterns, and to give a path
for the create view URL that does not match the edit URL pattern.

[ericholscher]

Seems simple enough 👍

[agjohnson]

I seem to recall @humitos having feedback on the URL structure, I'll wait for his feedback here.

[agjohnson]

Found the conversation, it was here: #7594 (comment)

My opinion is still that ../edit/ makes the most sense

[agjohnson]

The additional URL for the create view was causing errors with tests, so i did the more correct thing and made the URL conditional. Test look good now 👍

[humitos]

I don't want to block this work, but I made a comment with maybe a better explanation about why I think the /edit/ on the URL shouldn't be used at #7594 (comment)

It's not wrong using it, but I just find it easier to follow the conventions that Django and DRF are already using for these URLs.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[agjohnson]

This is blocking continuing to work on templates so I'd like to get this merged. To resurrect this discussion, some added context: the reason for the /edit/ postfix is because we need a corresponding URL for the create version view. Following patterns for other create/form views, there is a project version create URL:

/dashboard/pip/version/create/

However, if we don't change the edit form URL to ../edit/ postfix, the above URL for ProjectVersionCreate collides with the URL for ProjectVersionDetail where version=create. Adding an explicit ../edit/ postfix removes this overlap.

Using the ../edit/ postfix for update views is also an existing pattern we use, so nothing really new here.

If we want this to be even clearer, ProjectVersionDetail should really be ProjectVersionUpdate. This view is not a detail view at all, it is an admin only form view. I won't take this chunk on just yet, but can if it seems important to getting this merged.

[ericholscher]

I don't think the URL's matter nearly as much for the dashboard as the API, so I'm fine with whatever is most obvious, and hopefully we can standardize on it.

[humitos]

I re-read the whole conversation and I think Anthony is right 😄

As an example of this, Django Admin uses:

• /admin/auth/user/ to list all the users
• /admin/auth/user/add/ to create a new user
• /admin/auth/user/<pk>/change/ to edit a user

I understand that we are going to follow the same pattern but using /create/ and /edit/ instead of /add/ and /change/, so 👍