-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Move inactivate version list to standard CRUD UI pattern #6238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
Milestone
Comments
agjohnson
added a commit
that referenced
this issue
Oct 23, 2020
This is not currently used outside the new theme, but enables the solution for #6238 -- latest `master` of the new theme already expects this code. For now, the create URL does throw and exception, because we are rendering template code inside the version form. I'm not going to address this as the create view is not linked and unused, and we probably shouldn't be rendering templates inside form instantiation anyways. The edit version URL does change with this, to append the `/edit/` postfix. This was done to match similar URL patterns, and to give a path for the create view URL that does not match the edit URL pattern.
agjohnson
added a commit
that referenced
this issue
Oct 23, 2020
This is not currently used outside the new theme, but enables the solution for #6238 -- latest `master` of the new theme already expects this code. For now, the create URL does throw and exception, because we are rendering template code inside the version form. I'm not going to address this as the create view is not linked and unused, and we probably shouldn't be rendering templates inside form instantiation anyways. The edit version URL does change with this, to append the `/edit/` postfix. This was done to match similar URL patterns, and to give a path for the create view URL that does not match the edit URL pattern.
This is addressed in the new templates already and will be resolved with a beta release of the theme. |
agjohnson
added a commit
that referenced
this issue
Oct 23, 2020
This is not currently used outside the new theme, but enables the solution for #6238 -- latest `master` of the new theme already expects this code. For now, the create URL does throw and exception, because we are rendering template code inside the version form. I'm not going to address this as the create view is not linked and unused, and we probably shouldn't be rendering templates inside form instantiation anyways. The edit version URL does change with this, to append the `/edit/` postfix. This was done to match similar URL patterns, and to give a path for the create view URL that does not match the edit URL pattern.
agjohnson
added a commit
that referenced
this issue
Nov 20, 2020
This is not currently used outside the new theme, but enables the solution for #6238 -- latest `master` of the new theme already expects this code. For now, the create URL does throw and exception, because we are rendering template code inside the version form. I'm not going to address this as the create view is not linked and unused, and we probably shouldn't be rendering templates inside form instantiation anyways. The edit version URL does change with this, to append the `/edit/` postfix. This was done to match similar URL patterns, and to give a path for the create view URL that does not match the edit URL pattern.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We are addressing a bug with our version display with #6224. This is an intermediate fix for a bug in the display, the final version to move towards would move us to a standardized pattern for our CRUD interfaces and probably isn't something we'd take on until we are using SUI and have a strong UI base to work from.
We have UI standardization notes about moving towards common UI patterns, so I won't reiterate here. The point of this next step for version admin would be to remove the pattern we're using in the UI here in favor of a UI/UX that is predictable and expected from the user's perspective.
In this case, standardization would involve:
Why?
Examples
Mockups, using live loaded SUI, so the CSS is all wonky. You get the idea.
I loaded 50,000 version objects into search for this. The front end can handle a large number of branches without issue, but the bug that users are noticing could still be present if we're loading all versions through an API call instead of passing into the template. It might be necessary to do a filter on the API call, though would probably be worth testing without. There are several mechanisms we can play with here.
Going to leave this until we aren't blocked on SUI anymore.
The text was updated successfully, but these errors were encountered: