Add APIv3 version edit URL #7594
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agjohnson
added
Accepted
humitos
approved these changes
Oct 26, 2020
For use in dashboard client code, having a link to the dashboard for some resources would be helpful, and would avoid exposing the url resolver through Django to the JS side.
agjohnson
force-pushed
the
agj/apiv3-version-edit-url
branch
from
37d81d0 to
dade299
Compare
|
I'd like to push this PR forward if possible. Merging this would help reduce the volume of the rat's nest of code I've created to make templates work. |
humitos
reviewed
Apr 6, 2021
Moving from urls.edit to urls.dashboard.edit
|
Updated with the feedback on API return data structure. I think I did it right 🤷 |
stsewd
added a commit
that referenced
this pull request
Jun 7, 2021
Merged
stsewd
added a commit
that referenced
this pull request
Jun 7, 2021
Tests weren't updated after changing things in #7594
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For use in dashboard client code, having a link to the dashboard for
some resources would be helpful, and would avoid exposing the url
resolver through Django to the JS side.
Requires #7595