Warn about projects to be deleted whe an account is deleted #6414
Conversation
stsewd
commented
Nov 27, 2019
stsewd
commented
There was a problem hiding this comment.
I think this is good. I've done some suggestions regarding the UI, but probably @agjohnson is a better reviewer on this.
| <p> | ||
| <p> | ||
| <strong>All projects where you are the only owner will be deleted.</strong> | ||
| If you want to keep a project, add another owner or transfer ownership. |
There was a problem hiding this comment.
I think we could add a subtitle here. What about something like this?
Delete Account
All projects where you are the only owner will be deleted.
If you want to keep a project, add another owner or transfer ownership.
Projects to be delete
The following projects and all their documentation will be deleted:
- Project A
- Project B
There was a problem hiding this comment.
👍 on the heading, we can skip the paragraph below the heading which is redundant.
Co-Authored-By: Manuel Kaufmann <[email protected]>
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
@agjohnson would be good to get this reviewed. |
| @@ -25,3 +25,9 @@ def sort_version_aware(versions): | |||
| def is_project_user(user, project): | |||
| """Return if user is a member of project.users.""" | |||
| return user in project.users.all() | |||
|
|
|||
|
|
|||
| @register.filter | |||
There was a problem hiding this comment.
Is there a reason why this is a filter rather than just data set on the context in AccountDelete? It seems a somewhat awkward filter.
There was a problem hiding this comment.
Sorry for the late reply. After reading the code again and the one on .com, I think it was because we need to override this on .com, but I'll see if I can use the SetttingsObjectOverride pattern here
There was a problem hiding this comment.
Managed to get it working with SettingsOverride :)
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
stsewd
added
Accepted
|
|
||
| {% block delete-warning %} | ||
| <p> | ||
| <p> |
There was a problem hiding this comment.
I don't believe nested <p> is valid, and shouldn't be required either way.
| {% block delete-warning %} | ||
| <p> | ||
| <p> | ||
| <strong>All projects where you are the only owner will be deleted.</strong> |
There was a problem hiding this comment.
Untranslated string here. Also is this the messaging we'll give to commercial users?
| <p> | ||
| <p> | ||
| <strong>All projects where you are the only owner will be deleted.</strong> | ||
| If you want to keep a project, add another owner or transfer ownership. |
There was a problem hiding this comment.
👍 on the heading, we can skip the paragraph below the heading which is redundant.
There is a PR to override this in .com (744) |
|
Replaced with #9164 |
