Warn about projects to be deleted whe an account is deleted

readthedocs/core/signals.py

@@ -1,5 +1,3 @@
-# -*- coding: utf-8 -*-
-
 """Signal handling for core app."""
 
 import logging
@@ -14,7 +12,7 @@
 
 from readthedocs.oauth.models import RemoteOrganization
 from readthedocs.projects.models import Domain, Project
-
+from readthedocs.projects.utils import get_projects_last_owner
 
 log = logging.getLogger(__name__)
 
@@ -84,23 +82,15 @@ def decide_if_cors(sender, request, **kwargs):  # pylint: disable=unused-argumen
 
 @receiver(pre_delete, sender=settings.AUTH_USER_MODEL)
 def delete_projects_and_organizations(sender, instance, *args, **kwargs):
-    # Here we count the owner list from the projects that the user own
-    # Then exclude the projects where there are more than one owner
-    # Add annotate before filter
-    # https://github.com/rtfd/readthedocs.org/pull/4577
-    # https://docs.djangoproject.com/en/2.1/topics/db/aggregation/#order-of-annotate-and-filter-clauses # noqa
-    projects = (
-        Project.objects.annotate(num_users=Count('users')
-                                 ).filter(users=instance.id
-                                          ).exclude(num_users__gt=1)
-    )
+    user = instance
+    projects = get_projects_last_owner(user)
 
     # Here we count the users list from the organization that the user belong
     # Then exclude the organizations where there are more than one user
     oauth_organizations = (
-        RemoteOrganization.objects.annotate(num_users=Count('users')
-                                            ).filter(users=instance.id
-                                                     ).exclude(num_users__gt=1)
+        RemoteOrganization.objects
+        .annotate(num_users=Count('users'))
+        .filter(users=instance.id, num_users=1)
     )
 
     projects.delete()

readthedocs/projects/templatetags/projects_tags.py

@@ -2,9 +2,9 @@
 
 from django import template
 
+from readthedocs.projects.utils import get_projects_last_owner
 from readthedocs.projects.version_handling import comparable_version
 
-
 register = template.Library()
 
 
@@ -25,3 +25,9 @@ def sort_version_aware(versions):
 def is_project_user(user, project):
     """Return if user is a member of project.users."""
     return user in project.users.all()
+
+
+@register.filter
+def projects_last_owner(user):
+    """Returns projects where `user` is the last owner."""
+    return get_projects_last_owner(user)

readthedocs/projects/utils.py

@@ -1,10 +1,9 @@
 """Utility functions used by projects."""
-
 import logging
 import os
 
 from django.conf import settings
-
+from django.db.models import Count
 
 log = logging.getLogger(__name__)
 
@@ -56,3 +55,13 @@ class Echo:
     def write(self, value):
         """Write the value by returning it, instead of storing in a buffer."""
         return value
+
+
+def get_projects_last_owner(user):
+    """Get projects where `user` is the last owner."""
+    from readthedocs.projects.models import Project
+    return (
+        Project.objects
+        .annotate(num_users=Count('users'))
+        .filter(users=user.id, num_users=1)
+    )

readthedocs/templates/profiles/private/delete_account.html

@@ -1,6 +1,7 @@
 {% extends "profiles/base_profile_edit.html" %}
 
 {% load i18n %}
+{% load projects_tags %}
 
 {% block title %}{% trans "Delete Account" %}{% endblock %}
 
@@ -9,12 +10,31 @@
 {% block edit_content_header %} {% trans "Delete Account" %} {% endblock %}
 
 {% block edit_content %}
+
+  {% block delete-warning %}
+    <p>
+      <p>
+        <strong>All projects where you are the only owner will be deleted.</strong>
+        If you want to keep a project, add another owner or transfer ownership.
+        The next projects and all its information will be deleted.
+      </p>
+      <ul>
+        {% for project in user|projects_last_owner %}
+          <li>
+            <a href="{{ project.get_absolute_url }}">{{ project.slug }}</a>
+          </li>
+        {% endfor %}
+      </ul>
+    </p>
+  {% endblock%}
+
   <form method="POST" action=".">
     {% csrf_token %}
     {{ form }}
     <div>
       <strong>{% trans "Be careful! This can not be undone!" %}</strong>
     </div>
     <input type="submit" name="submit" value="{% trans "Delete Account" %}" id="submit"/>
-  </form>
+  </form>  
+
 {% endblock %}