User: delete organizations where the user is the last owner #9164
Conversation
This also shows a warning with a list of projects/organizations to be deleted.
readthedocs/projects/querysets.py
Outdated
| def only_owner(self, user): | ||
| """ | ||
| Returns projects where `user` is the only owner. | ||
|
|
||
| Projects that belong to organizations aren't included. | ||
| """ |
There was a problem hiding this comment.
Reading the comment here I think it's clear. What about naming this method "solo_owner" instead? I think it's easier to read and will avoid the confusion that I had in the previous comment. cc @ericholscher
Note this also applies for the method in the organization manager
There was a problem hiding this comment.
solo doesn't seem more clear to me than only. We can probably be more verbose if needed.. is_single_owner? But I think the original name is mostly fine.
There was a problem hiding this comment.
I wouldn't prepend is_ to it because I'd expect a Yes/No (boolean) answer in that case. I think Project.objects.single_owner works better for me than only_onwer 👍🏼
| <ul> | ||
| {% for project in organization.projects.all %} | ||
| <li> | ||
| <a href="{{ project.get_absolute_url }}">{{ project.slug }}</a> |
There was a problem hiding this comment.
We should present this with Project: or similar.
This also shows a warning with a list of projects/organizations to be
deleted
Fixes https://github.com/readthedocs/readthedocs-corporate/issues/742