API V3 Subproject Creation Bug fix

[saadmk11]

fixes: #6271

[stsewd]

Changes look good. I'm leaving some suggestions to have more explicit tests. Also, I'm pushing some tests for the UI form, I was in the process of fixing this when I saw this PR p:

[stsewd]

Oh, and looks like all validation errors from the subproject serializer are missing i18n, can you add it?

[saadmk11]

Changes look good. I'm leaving some suggestions to have more explicit tests. Also, I'm pushing some tests for the UI form, I was in the process of fixing this when I saw this PR p:

Sure thanks :)

Oh, and looks like all validation errors from the subproject serializer are missing i18n, can you add it?

Okay :)

[humitos]

I was almost sure that I was going to make a mistake with this logic. I'm happy that you solved the issue. Thanks!

When working on this, I asked myself if it wouldn't be better to move the logic outside the Form and share it with the Serializer. After the bug that I introduced, I'd say it's clear that we have to do that instead of replicating the same logic. I want a function is_valid_as_subproject(project, subproject) raising different customized exceptions that we can handle properly on the Form and Serializer.

[saadmk11]

I was almost sure that I was going to make a mistake with this logic. I'm happy that you solved the issue. Thanks!

When working on this, I asked myself if it wouldn't be better to move the logic outside the Form and share it with the Serializer. After the bug that I introduced, I'd say it's clear that we have to do that instead of replicating the same logic. I want a function is_valid_as_subproject(project, subproject) raising different customized exceptions that we can handle properly on the Form and Serializer.

I think we can have 2 methods that will check is_valid_as_subproject and is_valid_as_superproject or we can have 1 method that checks both like is_valid_project_relation(project, subproject). What do you suggest? :)

Should I update this PR with that or Its alright for now?

But not sure how to raise different customized exceptions that we can handle properly on the Form and Serializer without any hack. like passing the validation error class

[humitos]

I think we can have 2 methods that will check is_valid_as_subproject and is_valid_as_superproject or we can have 1 method that checks both like is_valid_project_relation(project, subproject). What do you suggest? :)

Two methods are more explicit to me.

Should I update this PR with that or Its alright for now?

I think this refactor can be done in another PR. Do you want to work on that as well?

[saadmk11]

I think this refactor can be done in another PR. Do you want to work on that as well?

@humitos Sure! 👍 I'll send a PR Soon